Merge ~kwmonroe/layer-snap:master into ~stub/layer-snap:master
Proposed by
Kevin W Monroe
Status: | Merged |
---|---|
Merged at revision: | 11aefcb91e1f2b63de4ae685a8b90f9babfd9f9f |
Proposed branch: | ~kwmonroe/layer-snap:master |
Merge into: | ~stub/layer-snap:master |
Diff against target: |
24 lines (+3/-3) 1 file modified
lib/charms/layer/snap.py (+3/-3) |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Stuart Bishop | Approve | ||
Review via email: mp+366290@code.launchpad.net |
Description of the change
In fixing bug 1823293, we had to take special care to handle whitespace returned by snap.get:
https:/
-----
sudo snap set core refresh.timer=''
...
>>> subprocess.
'\n'
-----
We *can* work around this by calling foo = snap.get().strip(), but I'm struggling to find a case where I'd want snap.get returning unstripped output. Hence, this MP strips output from the call to 'snap get'.
To post a comment you must log in.
Fine