Merge lp:~kwmonroe/charms/trusty/zulu8/promulgated-source into lp:~azulcharmers/charms/trusty/zulu8/source
Status: | Merged |
---|---|
Merged at revision: | 18 |
Proposed branch: | lp:~kwmonroe/charms/trusty/zulu8/promulgated-source |
Merge into: | lp:~azulcharmers/charms/trusty/zulu8/source |
Diff against target: |
148 lines (+62/-7) 5 files modified
Makefile (+8/-0) README.md (+4/-4) reactive/install (+15/-3) tests/01-deploy.py (+33/-0) tests/tests.yaml (+2/-0) |
To merge this branch: | bzr merge lp:~kwmonroe/charms/trusty/zulu8/promulgated-source |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Azul Charmers | Pending | ||
Review via email: mp+288727@code.launchpad.net |
Description of the change
This is the source branch that was used to build the Zulu8 charm available here:
https:/
I noticed this is a few commits ahead of your lp:~azulcharmers/charms/trusty/zulu8/source branch, so I wanted to create this merge proposal to get your branch updated. Notable changes:
+ include tests in the layered source (these were in your ./trunk branch, but they need to live in the ./source branch since that is where 'charm build' will look for them when creating a deployable charm)
+ minor README and logging updates (I noticed 'set -x' was causing a tremendous amount of juju debug-log output, so I removed it in favor of appropriate 'juju-log' statements)
+ send relation data when zulu version changes after install (I noticed the new java version and JAVA_HOME were not getting set when up/downgrading zulu after initial install)
Let me know if you have any questions/concerns over any of this. I'm excited to have zulu8 in the charm store as an alternative to other java environments! Thanks.