lp:~kwmonroe/charms/trusty/layer-ibm-im/switch-to-resources
- Get this branch:
- bzr branch lp:~kwmonroe/charms/trusty/layer-ibm-im/switch-to-resources
Branch merges
- Shruthima: Approve
-
Diff: 866 lines (+323/-463)9 files modifiedREADME.md (+115/-210)
config.yaml (+0/-6)
layer.yaml (+1/-0)
metadata.yaml (+13/-2)
reactive/ibm-im.sh (+161/-140)
tests/00-setup (+0/-21)
tests/01-deploy.py (+29/-0)
tests/10-bundles-test.py (+0/-84)
tests/tests.yaml (+4/-0)
Related source package recipes
Branch information
- Owner:
- Kevin W Monroe
- Status:
- Development
Recent revisions
- 21. By Kevin W Monroe
-
change upgrade-charm hook logic
The first time a fixpack resource was uploaded, the upgrade-charm hook would
fetch it, md5sum it, and compare that sum to a bogus previous value (because
there was no previous valid fixpack). This sum mismatch triggered the install
of a new fixpack, which goes out to re-fetch it. The double-fetch on initial
fixpack (first in upgrade-charm, then in install_ibm_im_ fixpack) is
inefficient.Instead, upgrade-charm now checks for the ibm-im.updated state, which is only
set when a fixpack gets installed. On initial fixpack upload, this state will
not be set, so we avoid the double fetch. - 16. By Kevin W Monroe
-
never let the grep fail when detecting an empty fixpack (set -e will make the hook fail on subshell failures); make check-fixpack only run during upgrade-charm (otherwise it ran on update-status, every 5 minutes)
Branch metadata
- Branch format:
- Branch format 7
- Repository format:
- Bazaar repository format 2a (needs bzr 1.16 or later)
