Merge lp:~kvalo/indicator-network/settings-passphrase-fix into lp:~indicator-applet-developers/indicator-network/indicator-network

Proposed by Kalle Valo
Status: Merged
Merged at revision: 148
Proposed branch: lp:~kvalo/indicator-network/settings-passphrase-fix
Merge into: lp:~indicator-applet-developers/indicator-network/indicator-network
Diff against target: 35 lines (+3/-4)
2 files modified
src/libconnman/connman-service.c (+2/-2)
src/settings/frontend/widgets/dialogs/edit-connection.vala (+1/-2)
To merge this branch: bzr merge lp:~kvalo/indicator-network/settings-passphrase-fix
Reviewer Review Type Date Requested Status
Mikkel Kamstrup Erlandsen (community) Approve
Review via email: mp+50161@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Mikkel Kamstrup Erlandsen (kamstrup) wrote :

Looks good

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/libconnman/connman-service.c'
2--- src/libconnman/connman-service.c 2011-02-15 10:24:00 +0000
3+++ src/libconnman/connman-service.c 2011-02-17 14:56:30 +0000
4@@ -1392,7 +1392,7 @@
5 if (priv->passphrase == NULL)
6 return;
7
8- value = g_variant_new("(s)", priv->passphrase);
9+ value = g_variant_new("s", priv->passphrase);
10
11 set_service_property(self, "Passphrase", value);
12 }
13@@ -1415,7 +1415,7 @@
14 if (priv->apn == NULL)
15 return;
16
17- value = g_variant_new("(s)", priv->apn);
18+ value = g_variant_new("s", priv->apn);
19
20 set_service_property(self, "APN", value);
21 }
22
23=== modified file 'src/settings/frontend/widgets/dialogs/edit-connection.vala'
24--- src/settings/frontend/widgets/dialogs/edit-connection.vala 2011-02-16 13:53:37 +0000
25+++ src/settings/frontend/widgets/dialogs/edit-connection.vala 2011-02-17 14:56:30 +0000
26@@ -218,8 +218,7 @@
27 }
28
29 private void save_passphrase() {
30- /* FIXME: fix libconnman */
31- // this.connection.passphrase = this.entry_passphrase.get_text();
32+ this.connection.passphrase = this.entry_passphrase.get_text();
33 }
34
35 private void update_ipv4() {

Subscribers

People subscribed via source and target branches