Connection Manager

Code review comment for lp:~kvalo/connman/ptp-default-gateway

  1. ptp-default-gateway
  2. Merge into trunk
Revision history for this message
David Barth (dbarth) wrote :

Comments and needs info:
- the del_routes changes seem correct to me
- connman_inet_clear_gateway_interface looks good to me
- rntl: sounds ok, but i'm not sure how safe it is to skip those host-specific routes

My only worry is about swapping a NULL for a "0.0.0.0" string. You've done the changes locally, but are there other parts of the code (or of plugins) where gateway != NULL (because it's now "0.0.0.0") would be mis-interpreted? Have you grepped for that in the rest of the code?

review: Needs Information

« Back to merge proposal