~kurt-easygo/cloud-init:master

Last commit made on 2019-02-27
Get this branch:
git clone -b master https://git.launchpad.net/~kurt-easygo/cloud-init
Only Kurt Stieger can upload to this branch. If you are Kurt Stieger please log in for upload directions.

Branch merges

Branch information

Name:
master
Repository:
lp:~kurt-easygo/cloud-init

Recent commits

f2f530e... by Dan Watkins on 2019-02-27

cc_apt_pipelining: stop disabling pipelining by default

This was introduced due to Ubuntu using S3 mirrors, and S3 having a
buggy pipelining implementation. Those Ubuntu mirrors are no longer in
production and, furthremore, apt has also grown the ability to handle
servers with broken pipelining.

As such, we can stop disabling pipelining, which should result in
improved apt download speeds.

LP: #1794982

1182ad5... by Dan Watkins on 2019-02-26

tests: fix some slow tests and some leaking state

In test_ds_identify, don't mutate otherwise-static test data. When
running tests in a random order, this was causing failures due to
breaking preconditions for other tests.

In tests/helpers, reset logging level in tearDown. Some of the CLI
tests set the level of the root logger in a way that isn't correctly
reset.

For test_poll_imds_re_dhcp_on_timeout and
test_dhcp_discovery_run_in_sandbox_warns_invalid_pid, mock out
time.sleep; this saves ~11 seconds (or ~40% of previous test time!).

f278a8a... by Dan Watkins on 2019-02-26

util: don't determine string_types ourselves

six already provides this for us, and we're already paying the cost to
determine it there; no need to do it twice.

f0f0962... by Dan Watkins on 2019-02-26

cc_rsyslog: Escape possible nested set

Under Python 3.7, we are seeing `FutureWarning: Possible nested set at
position 23`; escaping this bracket causes that warning to disappear.

LP: #1816967

8cfcc28... by Eric Williams on 2019-02-25

Enable encrypted_data_bag_secret support for Chef

Encrypted data bags require a secrets file to be present to
decrypt, and the location of the file must be configured the
Chef client configuration file, client.rb.

This update enables cloud-init's chef module to update that
setting in client.rb.

LP: #1817082

34f5436... by "Jason Zions \(MSFT\)" <email address hidden> on 2019-02-22

azure: Filter list of ssh keys pulled from fabric

The Azure data source is expected to expose a list of
ssh keys for the user-to-be-provisioned in the crawled
metadata. When configured to use the __builtin__ agent
this list is built by the WALinuxAgentShim. The shim
retrieves the full set of certificates and public keys
exposed to the VM from the wireserver, extracts any
ssh keys it can, and returns that list.

This fix reduces that list of ssh keys to just the
ones whose fingerprints appear in the "administrative
user" section of the ovf-env.xml file. The Azure
control plane exposes other ssh keys to the VM for
other reasons, but those should not be added to the
authorized_keys file for the provisioned user.

79d40e6... by Ryan Harper on 2019-02-22

doc: update merging doc with fixes and some additional details/examples

Update config merging documentation with cloud-config syntax fix. Add an
example showing how to merge two files with runcmd.

e7a8f81... by Chad Smith on 2019-02-22

tests: integration test failure summary to use traceback if empty error

When integration tests verification fails, the object returned
contains has 'error' and 'traceback' keys. Each key can contain empty
strings. If the simplified 'error' message is empty, fallback and use
the more verbose full 'traceback' text in the failure summary.

9cf9d8c... by Vitaly Kuznetsov on 2019-02-18

This is to fix https://bugs.launchpad.net/cloud-init/+bug/1812676

0bb4c74... by Guilherme G. Piccoli on 2019-02-14

EC2: Rewrite network config on AWS Classic instances every boot

AWS EC2 instances' network come in 2 basic flavors: Classic and VPC
(Virtual Private Cloud). The former has an interesting behavior of having
its MAC address changed whenever the instance is stopped/restarted. This
behavior is not observed in VPC instances.

In Ubuntu 18.04 (Bionic) the network "management" changed from ENI-style
(etc/network/interfaces) to netplan, and when using netplan we observe
the following block present in /etc/netplan/50-cloud-init.yaml:

match:
  macaddress: aa:bb:cc:dd:ee:ff

Jani Ollikainen noticed in Launchpad bug #1802073 that the EC2 Classic
instances were booting without network access in Bionic after stop/restart
procedure, due to their MAC address change behavior. It was narrowed down
to the netplan MAC match block, that kept the old MAC address after
stopping and restarting an instance, since the network configuration
writing happens by default only once in EC2 instances, in the first boot.

This patch changes the network configuration write to every boot in EC2
Classic instances, by checking against the "vpc-id" metadata information
provided only in the VPC instances - if we don't have this metadata value,
cloud-init will rewrite the network configuration file in every boot.

This was tested in an EC2 Classic instance and proved to fix the issue;
unit tests were also added for the new method is_classic_instance().

LP: #1802073

Reported-by: Jani Ollikainen <email address hidden>
Suggested-by: Ryan Harper <email address hidden>
Co-developed-by: Chad Smith <email address hidden>
Signed-off-by: Guilherme G. Piccoli <email address hidden>