Merge ~kumy/libravatar:bug-1781174 into ~libravatar/libravatar:master

Proposed by Mathieu Alorent
Status: Rejected
Rejected by: François Marier
Proposed branch: ~kumy/libravatar:bug-1781174
Merge into: ~libravatar/libravatar:master
Diff against target: 13 lines (+1/-1)
1 file modified
config/www.apache2.conf (+1/-1)
Reviewer Review Type Date Requested Status
François Marier Needs Fixing
Review via email: mp+349346@code.launchpad.net
To post a comment you must log in.
Revision history for this message
François Marier (fmarier) wrote :

I tried merging it but the SECCDNSERVERNAME placeholder isn't replaced by the postinst script and ends up in the final config.

It looks like some changes to the libravatar-www.postinst script will be needed as well.

review: Needs Fixing
Revision history for this message
Mathieu Alorent (kumy) wrote :

I was not using the Debian packages but sed in a Dockerfile.

Let's close if you wish.

On 15/07/2018 21:04, François Marier wrote:
> Review: Needs Fixing
>
> I tried merging it but the SECCDNSERVERNAME placeholder isn't replaced by the postinst script and ends up in the final config.
>
> It looks like some changes to the libravatar-www.postinst script will be needed as well.

Revision history for this message
François Marier (fmarier) wrote :

Ok, I won't have time to make the other changes and test this so let's park this for now.

Unmerged commits

b5b4c54... by Mathieu Alorent <email address hidden>

LP: #1781174 Add placeholder for Content-Security-Policy

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/config/www.apache2.conf b/config/www.apache2.conf
2index 2d082b5..220e9b8 100644
3--- a/config/www.apache2.conf
4+++ b/config/www.apache2.conf
5@@ -17,7 +17,7 @@
6
7 # Content Security Policy
8 # http://www.w3.org/TR/CSP/
9- Header set Content-Security-Policy: "default-src 'none' ; script-src 'self' https://ad.aloodo.com ; style-src 'self' ; img-src 'self' data: https://seccdn.libravatar.org"
10+ Header set Content-Security-Policy: "default-src 'none' ; script-src 'self' https://ad.aloodo.com ; style-src 'self' ; img-src 'self' data: https://__SECCDNSERVERNAME__"
11 <Location /account/confirm_email>
12 Header set Content-Security-Policy: "default-src 'none' ; script-src 'self' https://ad.aloodo.com ; style-src 'self' ; img-src * data:"
13 </Location>

Subscribers

People subscribed via source and target branches