juk

lp:~kubuntu-members/juk/4.11

Created by Philip Muškovac on 2013-07-14 and last modified on 2013-09-03
Get this branch:
bzr branch lp:~kubuntu-members/juk/4.11

Branch merges

Related bugs

Related blueprints

Branch information

Owner:
Kubuntu Members
Project:
juk
Status:
Development

Import details

Import Status: Reviewed

This branch is an import of the HEAD branch of the Git repository at git://anongit.kde.org/juk,branch=KDE%2F4.11.

The next import is scheduled to run in 5 hours.

Last successful import was 16 minutes ago.

Import started 16 minutes ago on alnitak and finished 16 minutes ago taking 15 seconds — see the log
Import started 7 hours ago on alnitak and finished 7 hours ago taking 15 seconds — see the log
Import started 13 hours ago on alnitak and finished 13 hours ago taking 15 seconds — see the log
Import started 19 hours ago on alnitak and finished 19 hours ago taking 15 seconds — see the log
Import started on 2019-08-22 on alnitak and finished on 2019-08-22 taking 15 seconds — see the log
Import started on 2019-08-22 on alnitak and finished on 2019-08-22 taking 15 seconds — see the log
Import started on 2019-08-21 on alnitak and finished on 2019-08-21 taking 20 seconds — see the log
Import started on 2019-08-21 on alnitak and finished on 2019-08-21 taking 15 seconds — see the log
Import started on 2019-08-21 on alnitak and finished on 2019-08-21 taking 15 seconds — see the log
Import started on 2019-08-21 on alnitak and finished on 2019-08-21 taking 15 seconds — see the log

Recent revisions

2401. By Michael Pyne <email address hidden> on 2013-09-03

GIT_SILENT: Bump JuK version for KDE SC 4.11.2 release.

2400. By Michael Pyne <email address hidden> on 2013-09-03

scrobbler: Change Scrobbler owner to be JuK, not PlayerManager.

PlayerManager will always emit a track changed signal, which means the
Scrobbler will always have to receive it even if we're not scrobbling
(my last change to avoid making network requests when not using last.fm
broke this, it seems).

Instead move the Scrobbler into the base application class where we can
track whether scrobbling is enabled or not, and Do the Right Thing. I
don't have a last.fm account so although this should still work (I
think), I can't verify. I have verified that we at least don't crash
anymore. Martin, can you double-check when you get a chance?

FIXED-IN:4.11.2
BUG:323703

2399. By l10n daemon script <email address hidden> on 2013-07-24

SVN_SILENT made messages (.desktop file)

2398. By Michael Pyne <email address hidden> on 2013-07-14

coverinfo: Do not crash if an MP3 file has no ID3 tag.

This rarely happens since taglib will simply create an ID3 tag if one
didn't exist before... but taglib can't do this if it can't find the
file, which now seems to occur for files with a non-UTF8 filename
encoding.

You see this as a 'Couldn't resolve the mime type of <<foo>> -- this
shouldn't happen' message on the console. In this situation JuK is able
to resolve the file to an appropriate TagLib::File subclass, but the
TagLib object is in an invalid state.

CoverInfo wasn't checking for this (it was assuming any TagLib::File*
that it was given was valid).

I took a look through the reported JuK crasher bugs and didn't see
anything relevant.

I'm not sure whether this will end up in the KDE SC 4.11 or 4.11.1.

2397. By Michael Pyne <email address hidden> on 2013-06-30

cache: Remove unneeded FileHandleHash class.

2396. By Michael Pyne <email address hidden> on 2013-06-30

cache: Port completely off of FileHandleHash.

Since Cache no longer also acts as a collection of FileHandles there's
no need for FileHandleHash. Get rid of it, replace its one use by the
equivalent data structure within CollectionList.

2395. By Michael Pyne <email address hidden> on 2013-06-29

mpris2: Make some adapter methods async.

This is another attempt to work around JuK <=> Plasma DBus deadlocks,
but making some of the DBus methods that Plasma would call into via the
MPRIS2 interface be async.

2394. By Michael Pyne <email address hidden> on 2013-06-29

mpris2: Move DBus adapter creation until after GUI setup.

This helps a little bit with JuK freezing Plasma due to DBus deadlocks
from synchronous calls being made between KStatusNotifierItem, its
Plasma notification area counterpart, and the MPRIS2 adapter and its
Plasma counterpart(s).

Proper fix is async everywhere as far as I can tell.

2393. By Michael Pyne <email address hidden> on 2013-06-29

play-queue: Remove an unneeded processEvents.

The effect is simulated by using deleteLater(). I have been unable to
reproduce any crash this way so hopefully whatever is mentioned in the
old comment does not apply to this new code.

2392. By Michael Pyne <email address hidden> on 2013-06-29

lyrics: Don't make network requests when lyrics are invisible.

Branch metadata

Branch format:
Branch format 7
Repository format:
Bazaar repository format 2a (needs bzr 1.16 or later)
This branch contains Public information 
Everyone can see this information.