Merge ~kstenerud/ubuntu/+source/mysql-5.7:cosmic-mysql-frozen-1799763 into ubuntu/+source/mysql-5.7:ubuntu/cosmic-devel

[Karl Stenerud]

This patch fixes frozen state handling in MySQL:

- Do not proceed in preinst if already in frozen state to prevent daemon
  stop if it had been started manually.
- Log to syslog via logger to increase visibility of the problem.
- Prevent systemd service start when in frozen state.

PPA: ppa:kstenerud/cosmic-mysql-frozen-1799763

Steps to test:

# lxc launch ubuntu:cosmic tester
# lxc exec tester bash
# apt update
# apt dist-upgrade -y
# apt install -y mysql-server
# apt remove -y mysql-server
# apt install -y mariadb-server
# apt remove -y mariadb-server
# apt install -y mysql-server

Pop up window:
 Automatic maintenance of MySQL server daemon disabled

 Packaging maintainer scripts detected a case that it does not know how to handle and cannot continue configuring MySQL. Automatic management of your MySQL installation has been disabled to allow other packaging tasks to complete. For more details, see /etc/mysql/FROZEN.

Console:

 Packaging maintenance of MySQL will stop and the daemon disabled to prevent damage to your system.
 For help, see /etc/mysql/FROZEN

# journalctl -xe
(nothing in the journal)
#service mysql start
(starts successfully when it should error out)

---------------------------------

# lxc launch ubuntu:cosmic tester-fix
# lxc exec tester-fix bash
# add-apt-repository -y ppa:kstenerud/cosmic-mysql-frozen-1799763
# apt update
# apt dist-upgrade -y
# apt install -y mysql-server
# apt remove -y mysql-server
# apt install -y mariadb-server
# apt remove -y mariadb-server
# apt install -y mysql-server

Pop up window:
 Automatic maintenance of MySQL server daemon disabled

 Packaging maintainer scripts detected a case that it does not know how to handle and cannot continue configuring MySQL. Automatic management of your MySQL installation has been disabled to allow other packaging tasks to complete. For more details, see /etc/mysql/FROZEN.

Console:
 MySQL has been frozen to prevent damage to your system. Please see /etc/mysql/FROZEN for help.

# journalctl -xe
Nov 02 10:36:28 tester /etc/init.d/mysql[3598]: MySQL has been frozen to prevent damage to your system. Please see /etc/mysql/FROZEN for help.
# service mysql start
Job for mysql.service failed because the control process exited with error code.
See "systemctl status mysql.service" and "journalctl -xe" for details.
# journalctl -xe
Nov 02 10:37:31 tester mysql-systemd-start[3694]: MySQL has been frozen to prevent damage to your system. Please see /etc/mysql/FROZEN for help.
Nov 02 10:37:31 tester systemd[1]: mysql.service: Control process exited, code=exited status=1
Nov 02 10:37:31 tester systemd[1]: mysql.service: Failed with result 'exit-code'.
Nov 02 10:37:31 tester systemd[1]: Failed to start MySQL Community Server.

Package Tests:

autopkgtest [14:42:05]: test upstream: -----------------------]
autopkgtest [14:42:05]: test upstream: - - - - - - - - - - results - - - - - - - - - -
upstream PASS
autopkgtest [14:42:06]: @@@@@@@@@@@@@@@@@@@@ summary
smoke PASS
upstream PASS

[Robie Basak (racb)]

Looks good, thanks!

This is fine to upload to Ubuntu, but it will save future work if we could land it in VCS on Salsa directly. Did you get anywhere with getting a merge request filed there please?

review: Approve

db7d7f5... by Karl Stenerud on 2018-11-05

  * d/mysql-server-5.7.{pre,post}inst, d/additions/mysql-systemd-start: improve
    frozen state handling (LP: #1799763):
    - Do not proceed in preinst if already in frozen state to prevent daemon
      stop if it had been started manually.
    - Log to syslog via logger to increase visibility of the problem.
    - Prevent systemd service start when in frozen state.

c6a8d94... by Karl Stenerud on 2018-11-05

changelog

[Andreas Hasenack (ahasenack)]

What are we waiting for here, an upload to cosmic?

[Robie Basak (racb)]

I need to merge in Salsa, upload to unstable, and then sync to Ubuntu.

[Robie Basak (racb)]

This is now in disco-proposed.

diff --git a/debian/additions/mysql-systemd-start b/debian/additions/mysql-systemd-start
index 946efb5..7178f1a 100755
--- a/debian/additions/mysql-systemd-start
+++ b/debian/additions/mysql-systemd-start
@@ -20,6 +20,10 @@ get_mysql_option() {
         echo "$result"
 }
 sanity () {
+  if [ -e /etc/mysql/FROZEN -o -h /etc/mysql/FROZEN ]; then
+    echo "MySQL has been frozen to prevent damage to your system. Please see /etc/mysql/FROZEN for help."
+    exit 1
+  fi
   if [ ! -r /etc/mysql/my.cnf ]; then
     echo "MySQL configuration not found at /etc/mysql/my.cnf. Please create one."
     exit 1
diff --git a/debian/changelog b/debian/changelog
index 90df71f..9618212 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,3 +1,14 @@
+mysql-5.7 (5.7.24-0ubuntu0.18.10.2) cosmic; urgency=medium
+
+  * d/mysql-server-5.7.{pre,post}inst, d/additions/mysql-systemd-start: improve
+    frozen state handling (LP: #1799763):
+    - Do not proceed in preinst if already in frozen state to prevent daemon
+      stop if it had been started manually.
+    - Log to syslog via logger to increase visibility of the problem.
+    - Prevent systemd service start when in frozen state.
+
+ -- Karl Stenerud <[e-mail]>  Thu, 01 Nov 2018 17:20:06 +0100
+
 mysql-5.7 (5.7.24-0ubuntu0.18.10.1) cosmic-security; urgency=medium
 
   * SECURITY UPDATE: Update to 5.7.24 to fix security issues
diff --git a/debian/mysql-server-5.7.postinst b/debian/mysql-server-5.7.postinst
index d4be88d..a3323db 100755
--- a/debian/mysql-server-5.7.postinst
+++ b/debian/mysql-server-5.7.postinst
@@ -150,11 +150,12 @@ case "$1" in
     # remains active for a long period.
 
     if [ -e /etc/mysql/FROZEN -o -h /etc/mysql/FROZEN ]; then
+      error_message="MySQL has been frozen to prevent damage to your system. Please see /etc/mysql/FROZEN for help."
+      logger -p daemon.err -t /etc/init.d/mysql -i "$error_message"
       db_input critical mysql-server-$this_version/installation_freeze_mode_active || true
       db_go
       db_stop
-      echo "Packaging maintenance of MySQL will stop and the daemon disabled to prevent damage to your system." 1>&2
-      echo "For help, see /etc/mysql/FROZEN" 1>&2
+      echo "$error_message" 1>&2
       exit 0
     fi
 
diff --git a/debian/mysql-server-5.7.preinst b/debian/mysql-server-5.7.preinst
index e3891e4..6793167 100755
--- a/debian/mysql-server-5.7.preinst
+++ b/debian/mysql-server-5.7.preinst
@@ -87,18 +87,22 @@ for i in `ls $DATADIR/debian-*.flag 2>/dev/null`; do
   fi
 done
 if [ "$is_downgrade_attempt" = 1 ]; then
+  echo "Downgrade from (at least) $found_version to $this_version is not possible." 1>&2
   if [ -e /etc/mysql/FROZEN -o -h /etc/mysql/FROZEN ]; then
     echo "Warning: /etc/mysql/FROZEN already exists" >&2
   else
     ln -s ../../usr/share/doc/mysql-common/frozen-mode/downgrade /etc/mysql/FROZEN
   fi
+fi
+
+if [ -e /etc/mysql/FROZEN -o -h /etc/mysql/FROZEN ]; then
+  error_message="MySQL has been frozen to prevent damage to your system. Please see /etc/mysql/FROZEN for help."
+  logger -p daemon.err -t /etc/init.d/mysql -i "$error_message"
   db_fset mysql-server-$this_version/installation_freeze_mode_active seen false || true
   db_input critical mysql-server-$this_version/installation_freeze_mode_active || true
   db_go
   db_stop
-  echo "Downgrade from (at least) $found_version to $this_version is not possible." 1>&2
-  echo "Packaging maintenance of MySQL will stop and the daemon disabled to prevent damage to your system." 1>&2
-  echo "For help, see /etc/mysql/FROZEN" 1>&2
+  echo "$error_message" 1>&2
   exit 0
 fi