Merge lp:~kroq-gar78/ubuntu/quantal/mod-proxy-html/fix-1005425 into lp:ubuntu/quantal/mod-proxy-html

Proposed by Aditya V
Status: Work in progress
Proposed branch: lp:~kroq-gar78/ubuntu/quantal/mod-proxy-html/fix-1005425
Merge into: lp:ubuntu/quantal/mod-proxy-html
Diff against target: 50 lines (+19/-5) (has conflicts)
2 files modified
debian/changelog (+11/-0)
debian/postinst (+8/-5)
Text conflict in debian/changelog
To merge this branch: bzr merge lp:~kroq-gar78/ubuntu/quantal/mod-proxy-html/fix-1005425
Reviewer Review Type Date Requested Status
Andrew Starr-Bochicchio (community) Disapprove
Ubuntu branches Pending
Review via email: mp+109767@code.launchpad.net

Description of the change

I fixed the path of libxml.so.2 by using the debian/postinst script.

To post a comment you must log in.
Revision history for this message
Andrew Starr-Bochicchio (andrewsomething) wrote :

There are some remnants of a bzr conflict in debian/changelog

Also, I'm not sure we need to be using sed for this. Could you look at version 3.0.1-1.1 from Debian which is now in quantal?

It seems to fix this with:

diff -u mod-proxy-html-3.0.1/debian/conf/proxy_html.load mod-proxy-html-3.0.1/debian/conf/proxy_html.load
--- mod-proxy-html-3.0.1/debian/conf/proxy_html.load
+++ mod-proxy-html-3.0.1/debian/conf/proxy_html.load
@@ -1,2 +1,2 @@
-LoadFile /usr/lib/libxml2.so.2
+LoadFile libxml2.so.2
 LoadModule proxy_html_module /usr/lib/apache2/modules/mod_proxy_html.so

review: Needs Fixing
Revision history for this message
Andrew Starr-Bochicchio (andrewsomething) wrote :

The sync from Sid fixed this for quantal

review: Disapprove

Unmerged revisions

8. By Aditya V

debian/postinst: use 'uname' instead of 'dpkg-architecture' for path configuration

7. By Aditya V

debian/postinst: replace the path for libxml2.so.2 in field
'LoadFile' in file 'debian/conf/proxy_html.load' with the multiarch-
friendly path using sed (LP: #1005425)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/changelog'
2--- debian/changelog 2012-05-30 08:59:37 +0000
3+++ debian/changelog 2012-06-12 02:49:20 +0000
4@@ -1,3 +1,4 @@
5+<<<<<<< TREE
6 mod-proxy-html (3.0.1-1.1) unstable; urgency=medium
7
8 * Non-maintainer upload.
9@@ -13,6 +14,16 @@
10
11 -- Aron Xu <aron@debian.org> Wed, 30 May 2012 08:59:37 +0000
12
13+=======
14+mod-proxy-html (3.0.1-1ubuntu1) quantal; urgency=low
15+
16+ * debian/postinst: replace the path for libxml2.so.2 in field
17+ 'LoadFile' in file 'debian/conf/proxy_html.load' with the multiarch-
18+ friendly path using sed (LP: #1005425)
19+
20+ -- Aditya Vaidya <kroq.gar78@gmail.com> Mon, 28 May 2012 22:28:41 -0500
21+
22+>>>>>>> MERGE-SOURCE
23 mod-proxy-html (3.0.1-1) unstable; urgency=low
24
25 * New upstream release
26
27=== modified file 'debian/postinst'
28--- debian/postinst 2007-10-16 11:38:11 +0000
29+++ debian/postinst 2012-06-12 02:49:20 +0000
30@@ -40,12 +40,15 @@
31 reload_apache
32 fi
33 else
34- # Enable the module
35- if [ -e /etc/apache2/apache2.conf ]; then
36- a2enmod proxy_html >/dev/null || true
37- reload_apache
38+ # Enable the module
39+ if [ -e /etc/apache2/apache2.conf ]; then
40+ a2enmod proxy_html >/dev/null || true
41+ reload_apache
42+ fi
43 fi
44- fi
45+
46+ # Use multiarch-friendly paths for libxml.so.2 in proxy_html.load
47+ sed -i "s/\/usr\/lib\/libxml2.so.2/\/usr\/lib\/`uname -i`-linux-gnu\/libxml2.so.2/g" /etc/apache2/mods-available/proxy_html.load
48 ;;
49
50 abort-upgrade|abort-remove|abort-deconfigure)

Subscribers

People subscribed via source and target branches

to all changes: