Ubuntu
emesene package

Merge lp:~kroq-gar78/ubuntu/precise/emesene/fix-984504 into lp:ubuntu/precise/emesene

  1. Precise (12.04)
  2. fix-984504
  3. Merge into precise
Proposed by kroq-gar78 on 2012-04-28
Status: Rejected
Rejected by: James Westby on 2012-05-15
Proposed branch: lp:~kroq-gar78/ubuntu/precise/emesene/fix-984504
Merge into: lp:ubuntu/precise/emesene
Diff against target: 26 lines (+7/-1)
2 files modified
debian/changelog (+6/-0)
debian/control (+1/-1)
To merge this branch: bzr merge lp:~kroq-gar78/ubuntu/precise/emesene/fix-984504
Reviewer Review Type Date Requested Status
Andrew Starr-Bochicchio (community) Approve on 2012-05-11
Ubuntu branches 2012-04-28 Pending
Ken VanDine 2012-04-28 Pending
Mathieu Trudel-Lapierre 2012-04-28 Pending
Review via email: mp+103967@code.launchpad.net

This proposal supersedes a proposal from 2012-04-23.

Description of the Change

I added 'python-indicate' to the Depends field in debian/control of 'emesene'

To post a comment you must log in.
Mathieu Trudel-Lapierre (cyphermox) wrote : Posted in a previous version of this proposal

Looks correct, there's an 'import indicate' statement at the top of emesene/gui/common/MessagingMenu.py. Approve.

review: Approve
Ken VanDine (ken-vandine) wrote : Posted in a previous version of this proposal

> Looks correct, there's an 'import indicate' statement at the top of
> emesene/gui/common/MessagingMenu.py. Approve.

Actually I this should be a Recommends for python-indicate instead of a Depends. The dependency is optional, if the import fails (in emesene/gui/common/__init__.py) it is graceful and just doesn't register with the messaging menu. Actually the same is try for appindicator, so it looks like it should also have a Recommends added for python-appindicator.

review: Needs Fixing
kroq-gar78 (kroq-gar78) wrote : Posted in a previous version of this proposal

Okay I moved it from Depends to Recommends

Andrew Starr-Bochicchio (andrewsomething) :
review: Approve
Andrew Starr-Bochicchio (andrewsomething) wrote :

Looks good. I've uploaded to quantal, an will soon t precise-proposed.

Thanks!

Unmerged revisions

29. By kroq-gar78 on 2012-04-26

Removed the trailing comma for 'python-farstream', and updated debian/changelog

28. By kroq-gar78 on 2012-04-26

Changed 'python-indicate' from Depends to Reccomends

27. By kroq-gar78 on 2012-04-21

debian/control: add python-indicate to Depends field (LP: #984504)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/changelog'
2--- debian/changelog 2012-04-07 14:59:51 +0000
3+++ debian/changelog 2012-04-28 01:30:19 +0000
4@@ -1,3 +1,9 @@
5+emesene (2.12.3+dfsg-1ubuntu2) precise; urgency=low
6+
7+ * debian/control: add python-indicate to Reccomends field (LP: #984504)
8+
9+ -- Aditya Vaidya <kroq.gar78@gmail.com> Wed, 25 Apr 2012 22:05:49 -0500
10+
11 emesene (2.12.3+dfsg-1ubuntu1) precise; urgency=low
12
13 * Merge from Debian unstable (LP: #973926).
14
15=== modified file 'debian/control'
16--- debian/control 2012-04-07 14:59:51 +0000
17+++ debian/control 2012-04-28 01:30:19 +0000
18@@ -27,7 +27,7 @@
19 python-crypto,
20 python-gst0.10,
21 python-farstream
22-Recommends: python-xmpp, indicator-status-provider-emesene
23+Recommends: python-xmpp, indicator-status-provider-emesene, python-indicate
24 Suggests: python-gtkspell
25 Description: instant messaging client
26 emesene tries to be a simple but feature complete program that allows one to

Subscribers

People subscribed via source and target branches

to all changes: