Merge ~kotodama/charm-postfix-relay/+git/charm-postfix-relay:fix_auth_defaults into charm-postfix-relay:master

Proposed by Loïc Gomez
Status: Merged
Approved by: Haw Loeung
Approved revision: 003ea67a0c679ac6eeea36388851472642d293a3
Merged at revision: e32b5be9c21d639e772d8e145b710087b9196d4f
Proposed branch: ~kotodama/charm-postfix-relay/+git/charm-postfix-relay:fix_auth_defaults
Merge into: charm-postfix-relay:master
Diff against target: 14 lines (+2/-1)
1 file modified
src/templates/main.cf (+2/-1)
Reviewer Review Type Date Requested Status
Erhan Sunar (community) Approve
🤖 prod-jenkaas-bootstack (community) continuous-integration Approve
Haw Loeung +1 Approve
BootStack Reviewers Pending
Canonical BootStack Charmers Pending
Review via email: mp+440672@code.launchpad.net

Commit message

If auth parameters are set, disable anonymous sending of emails and set default auth mechanisms

Description of the change

When we set up auth params, we expect Postfix to authenticate.
Without these, Postfix sends emails without trying any form of authentication.
LOGIN and PLAIN are the mechanisms that can be used without other form of configuration.

To post a comment you must log in.
Revision history for this message
🤖 Canonical IS Merge Bot (canonical-is-mergebot) wrote :

This merge proposal is being monitored by mergebot. Change the status to Approved to merge.

Revision history for this message
Haw Loeung (hloeung) wrote :

LGTM

review: Approve (+1)
Revision history for this message
🤖 prod-jenkaas-bootstack (prod-jenkaas-bootstack) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
🤖 prod-jenkaas-bootstack (prod-jenkaas-bootstack) wrote :
review: Approve (continuous-integration)
Revision history for this message
Erhan Sunar (esunar) :
review: Approve
Revision history for this message
🤖 Canonical IS Merge Bot (canonical-is-mergebot) wrote :

Change successfully merged at revision e32b5be9c21d639e772d8e145b710087b9196d4f

Revision history for this message
Loïc Gomez (kotodama) wrote :

Many thanks!

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/src/templates/main.cf b/src/templates/main.cf
2index 966fec4..b9b6ef1 100644
3--- a/src/templates/main.cf
4+++ b/src/templates/main.cf
5@@ -19,7 +19,8 @@ smtp_use_tls = yes
6 {%- if enable_auth %}
7 smtp_sasl_auth_enable = yes
8 smtp_sasl_password_maps = hash:/etc/postfix/sasl_passwd
9-smtp_sasl_security_options =
10+smtp_sasl_security_options = noanonymous
11+smtp_sasl_mechanism_filter = plain,login
12 {%- endif %}
13
14 disable_vrfy_command = {{ disable_vrfy_command }}

Subscribers

People subscribed via source and target branches

to all changes: