Compiz

~kondor-dani/compiz:dbus-fix

  1. Git
  2. lp:~kondor-dani/compiz
  3. dbus-fix
Last commit made on 2020-05-21
Get this branch:
git clone -b dbus-fix https://git.launchpad.net/~kondor-dani/compiz
Only Daniel Kondor can upload to this branch. If you are Daniel Kondor please log in for upload directions.

Branch merges

Branch information

Name:
dbus-fix
Repository:
lp:~kondor-dani/compiz

Recent commits

dc00298... by Daniel Kondor

core: always remove the source from the list in EventManager::removeWatchFd()

It is safe to do so since it is a reference counted pointer -- the MainContex will still hold a reference for it.

This has a regression potential, mainly since if I'm wrong, this can introduce a race condition bug that is hard to
reproduce.

60b9c7f... by Daniel Kondor

potential fix for LP #1879975

In compiz::private_screen::EventManager::removeWatchFd(),
the CompWatchFd objects are only removed from the internal list, but are not
detached from the Glib::MainContext that they were attached to previously. I
believe this results in the Glib event loop still calling the original
callbacks registered on them.

This fixes the bug for me.

It has some regression potential if there is a component that relies on this
behavior. In my opinion this is not likely given that the CompWatchFd objects
are only created in EventManager::addWatchFd() and not reference to them is
kept after they are removed.

1b2352b... by CI Train Bot Account

Releasing 1:0.9.14.1+20.10.20200427-0ubuntu1

8abbe3a... by Alberts Muktupāvels

window-decorator: remove shade, stick and above buttons

20b3017... by Alberts Muktupāvels

ccsm: remove HeaderStyleSet (LP: #1863561)

Approved by: Dmitry Shachnev

5b797f9... by Alberts Muktupāvels

window-decorator: remove shade, stick and above buttons

1) These buttons are not supported by builtin Cairo theme and
Metacity will remove these buttons in next version.

2) These buttons are not supported by client side decorated
windows.

3) Few Metacity themes I checked had no icons for these buttons.
They had empty draw_ops...

Functionality itself is not removed! Still available using window
menu and/or keybindings.

e29b972... by Alberts Muktupāvels

ccsm: remove HeaderStyleSet

It was setting foreground color to background color (from selected
state). This seems wrong / unneeded with GTK 3.

https://bugs.launchpad.net/bugs/1863561

80aa95d... by CI Train Bot Account

Releasing 1:0.9.14.1+20.04.20200211-0ubuntu1

75e3dd9... by Dmitry Shachnev

* No-change rebuild to pick up cmake 3.16 path.

887c54b... by Dmitry Shachnev

No-change rebuild to pick up cmake 3.16 path.