Code review comment for lp:~kolmis/wxbanker/transaction-tagging

Revision history for this message
Karel Kolman (kolmis) wrote :

Michael, there are a few issues:
- i need access to bankModel in persistenStore; i had reverted the code that cached the bankModel in a persistentStore member variable, however i didn't realize the bankModel was used to access cached Tag objects. could you spare a simple explanation on the Model - Store coupling, or explain the way multiple models/stores are used in the unit tests (that failed by caching the bankModel)

- as for the tag column hiding, the visibility toggling you're suggesting seems like a good idea to me

- i was not aware of python's default argument once-only-evaluation, thanks for pointing that out

- i promised writing a few tests for the tags, i didn't get around to it yet (i admit there are times when i don't enjoy writing tests)

« Back to merge proposal