Code review comment for lp:~kobe24-lixiang/account-plugins/13.04

Alberto Mardegan (mardy) wrote :

Thanks Kobe for this plugin! Please, first check the indentation: in the Makefile.am files and in configure.ac, we use tabs, not spaces (you'll notice that in the diff below your lines are not correctly aligned with the others).

About targeting "trunk", you need to upgrade your system to use "saucy"; you can do this by replacing the lines in your /etc/apt/sources.list file from "raring" to "saucy". However, be warned that "saucy" is a development release and, as such, might be less stable than 13.04.
If you don't want to upgrade, feel free to continue using 13.04, but please set the target branch for this merge proposal to be "trunk". Even if you cannot build it: I'll try your patch and see if it builds and works (I think it will, because so far there are no changes in how the account plugins work from "raring" to "saucy").

review: Needs Fixing

« Back to merge proposal