Merge lp:~kobe24-lixiang/account-plugins/13.04 into lp:account-plugins/13.04
Status: | Needs review |
---|---|
Proposed branch: | lp:~kobe24-lixiang/account-plugins/13.04 |
Merge into: | lp:account-plugins/13.04 |
Diff against target: |
181 lines (+75/-1) 10 files modified
Makefile.am (+3/-0) configure.ac (+15/-0) data/providers/tencent.provider.in.in (+27/-0) data/services/Makefile.am (+1/-0) data/services/tencent-microblog.service.in (+8/-0) data/webkit-options/open.t.qq.com.conf (+4/-0) debian/account-plugin-tencent.install (+3/-0) debian/changelog (+4/-1) debian/control (+8/-0) src/config.vapi (+2/-0) |
To merge this branch: | bzr merge lp:~kobe24-lixiang/account-plugins/13.04 |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Alberto Mardegan (community) | Needs Fixing on 2013-06-10 | ||
Ken VanDine | 2013-06-08 | Disapprove on 2013-06-08 | |
Review via email:
|
Description of the change
Tencent-Microblog is very popular like Sina-Microblog in China. I had completed the authentication using oAuth2.0.
Then I'm going to do this work about friends-tencent like friends-sina and friends-sohu.
kobe (kobe24-lixiang) wrote : | # |
At first, I add code to trunk, but it depends on libaccounts-glib. In the source list, I can't get the package with the requested version.
So I get the libaccounts-glib code from launchpad to build package. There is still a problem about the build-depends requestment "automake (>=1:1.13)". Maybe there is other problem in my progress.
My system is UbuntuKylin 13.04, and I can't solve the question. So I had to use libaccounts-
I need your help to tell me what I shoud do if i use the trunk code.
Regards,
Kobe Lee.
At 2013-06-08 11:57:27,"Ken VanDine" <email address hidden> wrote:
>Review: Disapproveroatures should be targeted to trunk. Please resubmit the proposal against lp:account-plugins
>
>Thanks
>--
>https:/
>You are the owner of lp:~kobe24-lixiang/account-plugins/13.04.
Alberto Mardegan (mardy) wrote : | # |
Thanks Kobe for this plugin! Please, first check the indentation: in the Makefile.am files and in configure.ac, we use tabs, not spaces (you'll notice that in the diff below your lines are not correctly aligned with the others).
About targeting "trunk", you need to upgrade your system to use "saucy"; you can do this by replacing the lines in your /etc/apt/
If you don't want to upgrade, feel free to continue using 13.04, but please set the target branch for this merge proposal to be "trunk". Even if you cannot build it: I'll try your patch and see if it builds and works (I think it will, because so far there are no changes in how the account plugins work from "raring" to "saucy").
Great to see tencent support, but the 13.04 is a maintenance branch, bug fixes only. New features should be targeted to trunk. Please resubmit the proposal against lp:account-plugins
Thanks