Merge ~kobako/ubuntu/+source/alsa-ucm-conf:LP2015972_L into ubuntu/+source/alsa-ucm-conf:ubuntu/lunar-devel

Proposed by koba
Status: Needs review
Proposed branch: ~kobako/ubuntu/+source/alsa-ucm-conf:LP2015972_L
Merge into: ubuntu/+source/alsa-ucm-conf:ubuntu/lunar-devel
Diff against target: 71 lines (+49/-0)
3 files modified
debian/changelog (+7/-0)
debian/patches/0014-sof-hda-dsp-Add-speaker-led-support.patch (+41/-0)
debian/patches/series (+1/-0)
Reviewer Review Type Date Requested Status
Sebastien Bacher (community) Approve
git-ubuntu import Pending
Review via email: mp+441281@code.launchpad.net

Description of the change

BugLink: https://bugs.launchpad.net/bugs/2015972

[Feature Description]
When users press the speaker mute hotkey and the speaker is muted,
the speaker mute LED indicator will light up.
When the speaker is not muted,
the speaker mute LED indicator will light out.

[Test Case]
1. run G16 with target kernel.
2. press the mute hotkey
3. check if speaker mute led can be switched.

[Where problems could occur]
Low, just register a speaker mute led control for dell-laptop.

To post a comment you must log in.
Revision history for this message
Sebastien Bacher (seb128) wrote :

Thank you for your contribution, the change should not be inline though but in debian/patches and you should have a debian/changelog entry explaining the fix and referencing to the launchpad bug to close

review: Needs Fixing
Revision history for this message
koba (kobako) wrote :

@Seb128, thanks for reviewing and comment,
Have modified as per your comment,
1. add patch to debian/patches
2. add a entry in d/changelog

Revision history for this message
Sebastien Bacher (seb128) wrote :

Thanks, I've uploaded to the lunar queue now

review: Approve

Unmerged commits

600e042... by koba

1.2.6.3-1ubuntu9 (patches unapplied)

Imported using git-ubuntu import.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/debian/changelog b/debian/changelog
2index cef7216..95aa998 100644
3--- a/debian/changelog
4+++ b/debian/changelog
5@@ -1,3 +1,10 @@
6+alsa-ucm-conf (1.2.6.3-1ubuntu9) lunar; urgency=medium
7+
8+ * d/p/0014-sof-hda-dsp-Add-speaker-led-support.patch
9+ - Backport patch to fix speaker mute led (LP: #2015972)
10+
11+ -- Koba Ko <koba.ko@canonical.com> Wed, 19 Apr 2023 09:50:30 +0800
12+
13 alsa-ucm-conf (1.2.6.3-1ubuntu8) lunar; urgency=medium
14
15 * d/p/0001-ucm2-HDA-Update-Mic-LED-settings-for-ACP-DMIC.patch
16diff --git a/debian/patches/0014-sof-hda-dsp-Add-speaker-led-support.patch b/debian/patches/0014-sof-hda-dsp-Add-speaker-led-support.patch
17new file mode 100644
18index 0000000..293dd61
19--- /dev/null
20+++ b/debian/patches/0014-sof-hda-dsp-Add-speaker-led-support.patch
21@@ -0,0 +1,41 @@
22+From 6d4441b0398755c7f6e1b863d23d4f607243f3c2 Mon Sep 17 00:00:00 2001
23+From: KobaKo <koba.ko@canonical.com>
24+Date: Mon, 6 Mar 2023 20:22:51 +0800
25+Subject: [PATCH] sof-hda-dsp: Add speaker led support
26+
27+Fixes: https://github.com/alsa-project/alsa-ucm-conf/pull/302
28+Signed-off-by: KobaKo <koba.ko@canonical.com>
29+Signed-off-by: Jaroslav Kysela <perex@perex.cz>
30+(cherry picked from commit a2cabe3044075d53e4df0d4bb7c0818071e95e12)
31+Signed-off-by: Koba Ko <koba.ko@canonical.com>
32+---
33+ ucm2/Intel/sof-hda-dsp/sof-hda-dsp.conf | 13 +++++++++++++
34+ 1 file changed, 13 insertions(+)
35+
36+diff --git a/ucm2/Intel/sof-hda-dsp/sof-hda-dsp.conf b/ucm2/Intel/sof-hda-dsp/sof-hda-dsp.conf
37+index b47777b..35bd485 100644
38+--- a/ucm2/Intel/sof-hda-dsp/sof-hda-dsp.conf
39++++ b/ucm2/Intel/sof-hda-dsp/sof-hda-dsp.conf
40+@@ -51,6 +51,19 @@ If.speaker {
41+ ]
42+ }
43+
44++If.DellMuteLed {
45++ Condition {
46++ Type String
47++ Haystack "$${sys:class/leds/platform::mute/device}"
48++ Needle "dell-laptop"
49++ }
50++ True {
51++ FixedBootSequence [
52++ sysw "-/class/sound/ctl-led/speaker/card${CardNumber}/attach:Master Playback Switch"
53++ ]
54++ }
55++}
56++
57+ If.headphone {
58+ Condition {
59+ Type ControlExists
60+--
61+2.34.1
62+
63diff --git a/debian/patches/series b/debian/patches/series
64index 7b3df49..059fae2 100644
65--- a/debian/patches/series
66+++ b/debian/patches/series
67@@ -11,3 +11,4 @@ ucm2-sof-hda-dsp-If.devdmic-cleanup.patch
68 sof-hda-dsp-Set-Dmic0-Capture-Switch-on.patch
69 ucm2-sof-soundwire-Update-Mic-LED-settings.patch
70 0001-ucm2-HDA-Update-Mic-LED-settings-for-ACP-DMIC.patch
71+0014-sof-hda-dsp-Add-speaker-led-support.patch

Subscribers

People subscribed via source and target branches

to all changes: