Merge lp:~knome/wordpress-launchpad-integration/avoid-deprecated into lp:wordpress-launchpad-integration

Proposed by Pasi Lallinaho
Status: Needs review
Proposed branch: lp:~knome/wordpress-launchpad-integration/avoid-deprecated
Merge into: lp:wordpress-launchpad-integration
Diff against target: 25 lines (+2/-2)
2 files modified
launchpad_login.php (+1/-1)
openid-launchpad.php (+1/-1)
To merge this branch: bzr merge lp:~knome/wordpress-launchpad-integration/avoid-deprecated
Reviewer Review Type Date Requested Status
Canonical ISD hackers Pending
Review via email: mp+281750@code.launchpad.net

Description of the change

Avoids deprecation messages.

To post a comment you must log in.

Unmerged revisions

24. By Pasi Lallinaho

Avoid deprecation messages:
- Use capability 'add_users' instead of the deprecated user level 8 (administrator)
- Use esc_attr() instead of attribute_escape()

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'launchpad_login.php'
2--- launchpad_login.php 2011-07-29 19:54:56 +0000
3+++ launchpad_login.php 2016-01-06 14:01:17 +0000
4@@ -105,7 +105,7 @@
5 <input type="submit" name="launchpad" value="<?php echo
6 $login_button; ?>" id="lplogin" />
7 <input type="hidden" name="redirect_to"
8- value="<?php echo attribute_escape($redirect_to); ?>" />
9+ value="<?php echo esc_attr($redirect_to); ?>" />
10 <input type="hidden" name="testcookie" value="1" />
11 </div>
12 </form>
13
14=== modified file 'openid-launchpad.php'
15--- openid-launchpad.php 2011-07-29 20:08:09 +0000
16+++ openid-launchpad.php 2016-01-06 14:01:17 +0000
17@@ -53,7 +53,7 @@
18 */
19 function openid_launchpad_admin_panels() {
20 $hookname = add_options_page(__('Launchpad', 'openid-launchpad'),
21- __('Launchpad', 'openid-launchpad'), 8,
22+ __('Launchpad', 'openid-launchpad'), 'add_users',
23 'openid-launchpad',
24 'openid_launchpad_page' );
25 }

Subscribers

People subscribed via source and target branches