Merge lp:~knome/planet-ubuntu/prevent-img-pre-overlap into lp:planet-ubuntu

[Pasi Lallinaho]

Make sure <pre> elements do not overlap either. Also, the image overlap preventing code is moved to general.css too, since I noticed that images.css isn't even included.

Clearing all floats for <pre>-elements as requested.

[Anthony Dillon (ya-bo-ng)]

Thanks Pasi,

I am working on setting up a local version and staging for planet ubuntu. So I can test your MP's correctly. This shouldn't take to long. Just letting you know that your contribution's are not being missed.

Thanks again,
Ant.

[Pasi Lallinaho (knome)]

Hey Anthony, what's the status on this?

[Pasi Lallinaho (knome)]

Any update since one month?

[Pasi Lallinaho (knome)]

As we're experiencing this again on the production planet, is there any update on this since a month+?

[Anthony Dillon (ya-bo-ng)]

Sorry Pasi,

I struggled to set up a local version as I could not get access to the site. I will persue this next week.

[Pasi Lallinaho (knome)]

Sorry to bother again, but is there any update on this?

I don't think setting up a local setup of the site is needed for testing if this works or not. It's relatively simple CSS and its principle should be self-evident for people who understand CSS beyond the basics. Alternatively one can use developer tools to try these few lines live with the production installation.

[Elizabeth K. Joseph (lyz)]

I've independently reviewed this and it looks good. There are some images on the planet now that are over-sized so it's a good time to test it.

Can we please get this landed on Planet Ubuntu soon?

[Anthony Dillon (ya-bo-ng)]

Pasi,

Thank you very much and looks great. I have one small improvement mentioned in code. If you wouldn't mind addressing the comment. I will get the branch launched live.

review: Needs Fixing

[Pasi Lallinaho (knome)]

Added clearing as requested.

[Anthony Dillon (ya-bo-ng)]

Thank you very much.

review: Approve

[Anthony Dillon (ya-bo-ng)]

Update is merged and sent an RT to have the latest revision launched live.

[Pasi Lallinaho (knome)]

We still can't see this in production - is there an IS RT ticket we can follow-up on?

[Pasi Lallinaho (knome)]

Any update on this?

[Anthony Dillon (ya-bo-ng)]

Pasi,

Thank you for reminding me. It looks like that merge proposal has
conflicts. I'll resolve them and have it landed shortly.

Ant.

On Sat, 12 Sep 2015 11:29 Pasi Lallinaho <email address hidden> wrote:

> Any update on this?
> --
>
> https://code.launchpad.net/~knome/planet-ubuntu/prevent-img-pre-overlap/+merge/262957
> You are reviewing the proposed merge of
> lp:~knome/planet-ubuntu/prevent-img-pre-overlap into lp:planet-ubuntu.
>

=== modified file 'css/general.css'
--- css/general.css	2010-12-17 11:39:04 +0000
+++ css/general.css	2015-06-25 10:34:00 +0000
@@ -145,6 +145,16 @@
 {
 	float: left;
 	margin: 0 8px 8px 0;
+
+	max-width: 100%;
+	height: auto;
+}
+
+.post .entry-content pre {
+	clear: both;
+
+	max-width: 100%;
+	overflow: scroll;
 }
 
 .post .entry-utility