Merge lp:~knocte/ubuntu-themes/bring-back-zebra-striping into lp:ubuntu-themes

Proposed by Andres G. Aragoneses on 2014-01-03
Status: Merged
Approved by: Andrea Cimitan on 2014-01-14
Approved revision: 331
Merged at revision: 334
Proposed branch: lp:~knocte/ubuntu-themes/bring-back-zebra-striping
Merge into: lp:ubuntu-themes
Diff against target: 23 lines (+4/-2)
1 file modified
Ambiance/gtk-3.0/gtk-widgets.css (+4/-2)
To merge this branch: bzr merge lp:~knocte/ubuntu-themes/bring-back-zebra-striping
Reviewer Review Type Date Requested Status
PS Jenkins bot (community) continuous-integration Approve on 2014-01-14
Andrea Cimitan 2014-01-03 Approve on 2014-01-07
Review via email: mp+200429@code.launchpad.net

Commit message

Ambiance: support zebra striping for treeviews

This is a rework of Andrea's patch (committed in r220:
http://bazaar.launchpad.net/~ubuntu-art-pkg/ubuntu-themes/trunk/revision/220)
that doesn't introduce a visual glitch on progress bars
inside treeviews (because of this visual glitch, the
r220 patch was reverted in r234:
http://bazaar.launchpad.net/~ubuntu-art-pkg/ubuntu-themes/trunk/revision/234
and bug LP#945430 had to be reopened), and therefore
allows us to have a theme that implements zebra
striping treeviews when applications choose to use
them via `self.treeview.set_rules_hint(True)` API.

Description of the change

Ambiance: support zebra striping for treeviews

This is a rework of Andrea's patch (committed in r220:
http://bazaar.launchpad.net/~ubuntu-art-pkg/ubuntu-themes/trunk/revision/220)
that doesn't introduce a visual glitch on progress bars
inside treeviews (because of this visual glitch, the
r220 patch was reverted in r234:
http://bazaar.launchpad.net/~ubuntu-art-pkg/ubuntu-themes/trunk/revision/234
and bug LP#945430 had to be reopened), and therefore
allows us to have a theme that implements zebra
striping treeviews when applications choose to use
them via `self.treeview.set_rules_hint(True)` API.

To post a comment you must log in.
Andrea Cimitan (cimi) :
review: Approve
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'Ambiance/gtk-3.0/gtk-widgets.css'
2--- Ambiance/gtk-3.0/gtk-widgets.css 2013-11-25 16:46:01 +0000
3+++ Ambiance/gtk-3.0/gtk-widgets.css 2014-01-03 19:16:53 +0000
4@@ -1280,7 +1280,8 @@
5 .progressbar row,
6 .progressbar row:hover,
7 .progressbar row:selected,
8-.progressbar row:selected:focused {
9+.progressbar row:selected:focused,
10+.progressbar row:nth-child(odd) {
11 border-radius: 8px;
12 border-width: 0px;
13 background-image: none;
14@@ -2391,7 +2392,8 @@
15 }
16
17 GtkTreeView row:nth-child(odd) {
18- /*background-color: shade (@base_color, 0.965);*/
19+ /* zebra stripping, see LP#945430 */
20+ background-color: shade (@base_color, 0.965);
21 }
22
23 /************

Subscribers

People subscribed via source and target branches