Merge ~knobby/layer-snap:mwilson/is-installed into ~stub/layer-snap:master
Proposed by
Mike Wilson
Status: | Merged |
---|---|
Merged at revision: | 52675b6f6e7bb83362b2eae91ca8c105635fcbc5 |
Proposed branch: | ~knobby/layer-snap:mwilson/is-installed |
Merge into: | ~stub/layer-snap:master |
Diff against target: |
117 lines (+22/-10) 1 file modified
lib/charms/layer/snap.py (+22/-10) |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Stuart Bishop | Approve | ||
Review via email: mp+355505@code.launchpad.net |
This proposal supersedes a proposal from 2018-09-20.
To post a comment you must log in.
The idea is fine. I need the get_installed_ state_name and get_disabled_ state_name function names changed to match recommended nomenclature before I can land it (get_installed_flag and get_disabled_flag rather than _state_name)
My use cases just hard code the documented flag names, but I can see that the new methods will be useful when the set of snaps is configurable.