Merge lp:~knitzsche/ubuntu-rest-scopes/yahoofianance_news.finance_keyword into lp:ubuntu-rest-scopes

Proposed by Kyle Nitzsche on 2015-06-22
Status: Merged
Approved by: Bret Barker on 2015-06-23
Approved revision: 478
Merged at revision: 478
Proposed branch: lp:~knitzsche/ubuntu-rest-scopes/yahoofianance_news.finance_keyword
Merge into: lp:ubuntu-rest-scopes
Diff against target: 12 lines (+1/-1)
1 file modified
configs/scopes-info.yaml (+1/-1)
To merge this branch: bzr merge lp:~knitzsche/ubuntu-rest-scopes/yahoofianance_news.finance_keyword
Reviewer Review Type Date Requested Status
Facundo Batista 2015-06-22 Approve on 2015-06-23
David Callé (community) Approve on 2015-06-22
Review via email: mp+262593@code.launchpad.net

Commit Message

Add news.finance keyword to yahoofinance so News scope can still aggregate it after the next update

Description of the Change

Hi,

The news scope will now aggregate by "news.finance" keyword (not just "finance" because it is too generic).

This branch adds "news.finance" to yahoofinance scope.

Thanks,
Kyle

To post a comment you must log in.
David Callé (davidc3) wrote :

+1, thanks Kyle

review: Approve
Kyle Nitzsche (knitzsche) wrote :

Does this need a "top approve" too?

Facundo Batista (facundo) wrote :

Nice

review: Approve
Kyle Nitzsche (knitzsche) wrote :

I guess I cannot do the merge. Can someone please? This is needed for Yahoo Finance to show up in the News aggregator scope we are about to release.

Kyle Nitzsche (knitzsche) wrote :

I was asked for a commit message. here it is:

Add news.finance keyword to yahoofinance so News scope can still aggregate it after the next update

Ubuntu One Auto Pilot (otto-pilot) wrote :

There was a problem validating some authors of the branch. Authors must be either one of the listed Launchpad users, or a member of one of the listed teams on Launchpad.

Persons or Teams:

    ubuntu-rest-scopes-hackers

Unaccepted Authors:

    Kyle Nitzsche <email address hidden>

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'configs/scopes-info.yaml'
2--- configs/scopes-info.yaml 2015-05-04 12:40:08 +0000
3+++ configs/scopes-info.yaml 2015-06-22 15:05:10 +0000
4@@ -177,7 +177,7 @@
5 logo: logos/header-logo-yahoofinance.png
6 background: color:///#FFFFFF
7 divider-color: "#7D069E"
8- keywords: [business, finance]
9+ keywords: [business, finance, news.finance]
10
11 sevendigital:
12 name: 7digital

Subscribers

People subscribed via source and target branches