Merge lp:~knitzsche/ubuntu-html5-theme/ubuntu-html5-theme-fixes-1234979 into lp:~ubuntu-html5-theme-devs/ubuntu-html5-theme/ambiance

Proposed by Kyle Nitzsche
Status: Merged
Approved by: Alexandre Abreu
Approved revision: 86
Merged at revision: 86
Proposed branch: lp:~knitzsche/ubuntu-html5-theme/ubuntu-html5-theme-fixes-1234979
Merge into: lp:~ubuntu-html5-theme-devs/ubuntu-html5-theme/ambiance
Diff against target: 12 lines (+1/-1)
1 file modified
0.1/ambiance/js/buttons.js (+1/-1)
To merge this branch: bzr merge lp:~knitzsche/ubuntu-html5-theme/ubuntu-html5-theme-fixes-1234979
Reviewer Review Type Date Requested Status
PS Jenkins bot continuous-integration Approve
Adnane Belmadiaf Approve
Review via email: mp+189183@code.launchpad.net

Description of the change

Add button id to "Invalid button ID" error message

To post a comment you must log in.
Revision history for this message
Adnane Belmadiaf (daker) wrote :

+1, alex can approve this

review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file '0.1/ambiance/js/buttons.js'
2--- 0.1/ambiance/js/buttons.js 2013-07-19 00:08:53 +0000
3+++ 0.1/ambiance/js/buttons.js 2013-10-03 21:45:16 +0000
4@@ -28,7 +28,7 @@
5 Button.prototype = {
6 click: function (callback) {
7 if ( ! document.getElementById(this.id)) {
8- throw "Invalid button ID";
9+ throw "Invalid button ID: " + String(this.id);
10 }
11 new FastButton(document.getElementById(this.id), callback);
12 }

Subscribers

People subscribed via source and target branches