snappy-hwe-snaps

Merge ~knitzsche/snappy-hwe-snaps/+git/bluez:snap-20-twonewplugs into ~snappy-hwe-team/snappy-hwe-snaps/+git/bluez:snap-20

  1. Git
  2. lp:~knitzsche/snappy-hwe-snaps/+git/bluez
  3. snap-20-twonewplugs
  4. Merge into snap-20
Proposed by Kyle Nitzsche
Status: Merged
Approved by: Alfonso Sanchez-Beato
Approved revision: 213c6f7acc1236e1f113dee069e26389fea57397
Merged at revision: c603e0005c3e8fb199ec3aa524f2b6c483eaa6d1
Proposed branch: ~knitzsche/snappy-hwe-snaps/+git/bluez:snap-20-twonewplugs
Merge into: ~snappy-hwe-team/snappy-hwe-snaps/+git/bluez:snap-20
Diff against target: 21 lines (+2/-1)
1 file modified
snapcraft.yaml (+2/-1)
Reviewer Review Type Date Requested Status
System Enablement Bot continuous-integration Needs Fixing
Alfonso Sanchez-Beato continuous-integration Approve
Review via email: mp+393605@code.launchpad.net

Commit message

Add two plugs: uinput and kernel-krypto-api

To post a comment you must log in.
Revision history for this message
Alfonso Sanchez-Beato (alfonsosanchezbeato) wrote :

Each bluez app has its own list of plugs, should not these be used just by the "apps" that need them?

I am not sure also what happens if you add simply to the list of plugs, does it apply to all apps? (I've never added plugs this way, only when I needed to give them a name tbh).

Revision history for this message
Kyle Nitzsche (knitzsche) wrote :

Yes, I added them globally which means they apply to the whole snap.

Revision history for this message
System Enablement Bot (system-enablement-ci-bot) wrote :

PASSED: Successfully build documentation, rev: e33d01695602fdf85e1929a6f3c973abeff2a19b

Generated documentation is available at https://jenkins.canonical.com/system-enablement/job/snappy-hwe-snaps-snap-docs/1360/

Revision history for this message
System Enablement Bot (system-enablement-ci-bot) wrote :

FAILED: Continuous integration, rev:e33d01695602fdf85e1929a6f3c973abeff2a19b
https://jenkins.canonical.com/system-enablement/job/snappy-hwe-snaps-snap-build-prepare/538/
Executed test runs:
    FAILURE: https://jenkins.canonical.com/system-enablement/job/snappy-hwe-snaps-snap-build/ARCHITECTURE=amd64/571/console
    SUCCESS: https://jenkins.canonical.com/system-enablement/job/snappy-hwe-snaps-snap-build/ARCHITECTURE=arm64/571
    SUCCESS: https://jenkins.canonical.com/system-enablement/job/snappy-hwe-snaps-snap-build/ARCHITECTURE=armhf/571
    SUCCESS: https://jenkins.canonical.com/system-enablement/job/snappy-hwe-snaps-snap-build/ARCHITECTURE=i386/571
    SUCCESS: https://jenkins.canonical.com/system-enablement/job/snappy-hwe-snaps-snap-docs/1360
    SUCCESS: https://jenkins.canonical.com/system-enablement/job/snappy-hwe-snaps-snap-cleanup/1102
    None: https://jenkins.canonical.com/system-enablement/job/snappy-hwe-snaps-snap-update-mp/1151/console

Click here to trigger a rebuild:
https://jenkins.canonical.com/system-enablement/job/snappy-hwe-snaps-snap-build-prepare/538/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
Alfonso Sanchez-Beato (alfonsosanchezbeato) wrote :

LGTM

review: Approve
Revision history for this message
Alfonso Sanchez-Beato (alfonsosanchezbeato) wrote :

CI approval - tests are failing due to change on UC20 (no auto-import assertions in ubuntu-seed anymore). We will fix that later.

review: Approve (continuous-integration)
Revision history for this message
System Enablement Bot (system-enablement-ci-bot) wrote :

PASSED: Successfully build documentation, rev: 2acf1ec68e26d29423b60769329c72cb0f7d823a

Generated documentation is available at https://jenkins.canonical.com/system-enablement/job/snappy-hwe-snaps-snap-docs/1361/

Revision history for this message
System Enablement Bot (system-enablement-ci-bot) wrote :

FAILED: Continuous integration, rev:2acf1ec68e26d29423b60769329c72cb0f7d823a
https://jenkins.canonical.com/system-enablement/job/snappy-hwe-snaps-snap-build-prepare/539/
Executed test runs:
    FAILURE: https://jenkins.canonical.com/system-enablement/job/snappy-hwe-snaps-snap-build/ARCHITECTURE=amd64/572/console
    SUCCESS: https://jenkins.canonical.com/system-enablement/job/snappy-hwe-snaps-snap-build/ARCHITECTURE=arm64/572
    SUCCESS: https://jenkins.canonical.com/system-enablement/job/snappy-hwe-snaps-snap-build/ARCHITECTURE=armhf/572
    SUCCESS: https://jenkins.canonical.com/system-enablement/job/snappy-hwe-snaps-snap-build/ARCHITECTURE=i386/572
    SUCCESS: https://jenkins.canonical.com/system-enablement/job/snappy-hwe-snaps-snap-docs/1361
    SUCCESS: https://jenkins.canonical.com/system-enablement/job/snappy-hwe-snaps-snap-cleanup/1103
    None: https://jenkins.canonical.com/system-enablement/job/snappy-hwe-snaps-snap-update-mp/1152/console

Click here to trigger a rebuild:
https://jenkins.canonical.com/system-enablement/job/snappy-hwe-snaps-snap-build-prepare/539/rebuild

review: Needs Fixing (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/snapcraft.yaml b/snapcraft.yaml
2index 051271f..053753a 100644
3--- a/snapcraft.yaml
4+++ b/snapcraft.yaml
5@@ -29,7 +29,7 @@ apps:
6 command: "usr/lib/bluetooth/bluetoothd -E"
7 daemon: simple
8 slots: [service]
9- plugs: [uhid]
10+ plugs: [uhid, uinput, kernel-crypto-api]
11 obex:
12 command: "usr/lib/bluetooth/obexd"
13 daemon: simple
14@@ -65,6 +65,7 @@ apps:
15 plugs:
16 client:
17 interface: bluez
18+
19 slots:
20 service:
21 interface: bluez

Subscribers

People subscribed via source and target branches