lp:~knitzsche/scope-aggregator/refactor-handle-methods_add-login_remove-shared-category

Branch merges

Propose for merging

No branches dependent on this one.

Merged into lp:scope-aggregator at revision 174

Zhang Enwei (community): Approve on 2016-11-02

Gary.Wang: Pending requested 2016-09-30

Diff: 3725 lines (+1703/-1386)

15 files modified

DELETED_FEATURES.md (+1/-0)
README.md (+270/-286)
gtests/CMakeLists.txt (+4/-0)
gtests/MockRegistry.h (+7/-0)
gtests/scope_directory/login_1.json (+74/-0)
gtests/scope_directory/login_2.json (+73/-0)
gtests/scope_directory/login_3.json (+35/-0)
gtests/scope_test.cpp (+110/-3)
include/aggchildscope.h (+36/-1)
include/query.h (+16/-9)
src/CMakeLists.txt (+1/-0)
src/aggchildscope.cpp (+34/-1)
src/handle_results.cpp (+960/-0)
src/query.cpp (+2/-9)
src/utils.cpp (+80/-1077)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Related blueprints

191. By Kyle Nitzsche on 2016-09-30

suppress qt log messages

190. By Kyle Nitzsche on 2016-09-29

updated docs (README.md)

189. By Kyle Nitzsche on 2016-09-29

regularized RunType across the three handle methods: scope, category, keyword.

changed name of handle_current_child_scopes to complete_child_scopes and
dropped its now unused args.

188. By Kyle Nitzsche on 2016-09-29

mid-rewrite on README.md

187. By Kyle Nitzsche on 2016-09-28

updated README.md. Note that keyword no longer supports shared_category.

added DELETED_FEATURES.md, which lists keyword > shared_category

186. By Kyle Nitzsche on 2016-09-28

add bool Query::is_using_departments() and add this to two gtests

185. By Kyle Nitzsche on 2016-09-28

make handle_category_child() handle firstResult and not first result with
link to child specified and not.

184. By Kyle Nitzsche on 2016-09-27

refactored handle_keywords as previous pattern

183. By Kyle Nitzsche on 2016-09-22

for the new login_renderer gtests, also verify that the is_login_case()
method returns false when the incoming result category id does NOT equal
the declared login_renderer_incoming_category_id. That is, ensure the login
renderer code is not invoked when it should not be invoked.

182. By Kyle Nitzsche on 2016-09-22

add gtest: is_login_case_declared_scope
this verifies that for a declared child scope using the new login_renderer
feature, the is_login_case() method returns true when it should.