lp:~knielsen/drizzle/innodb-fixes

Branch merges

Propose for merging

No branches dependent on this one.

Merged into lp:~drizzle-trunk/drizzle/development

Drizzle Developers: Pending requested 2008-11-28

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Related blueprints

636. By Kristian Nielsen <knielsen@odin> on 2008-11-30

Remove last trace of Field_string.

This is also needed to fix a serious problem with multi_update as seen
with Valgrind errors in the main.update test. The multi_update creates
temporary tables with Field_string fields, but there are cast to
Field_varstring in Copy_field::get_copy_func() since both field types
are now DRIZZLE_TYPE_VARCHAR.

(an alternative would be to re-introduce Field_string as an
internal-only field type, and give it a distinct DRIZZLE_TYPE_FIXCHAR
type for get_copy_func() to check for.)

635. By Kristian Nielsen <knielsen@odin> on 2008-11-30

A couple more fixes of previous bmove()->memcpy(), changed to
memmove() due to potential for overlapping source and destination.

634. By Kristian Nielsen <knielsen@odin> on 2008-11-29

Remove #ifdef HAVE_purify. It is not worth it to save one well-predicted conditional at the cost of relying on undefined memcpy() semantics.

633. By Kristian Nielsen <knielsen@odin> on 2008-11-29

Take Mats'es changes from bmove()->memcpy(), and fix all of them to be
memmove() instead. I checked several of them, all of which were wrong
(due to potentially overlapping source and destination), so most
likely more of them are wrong. Painstakingly checking all of them for
whether memcpy() could be used instead would be a very big and
errorprone task, and really is not worth it.

Fixes a bunch of Valgrind errors in the test suite as well.

632. By Kristian Nielsen <knielsen@odin> on 2008-11-28

Fix bad patch that errorneously replaced Field_long::{un,}pack() with
Field_int64_t::{un,}pack() (oops!).

This should greatly help get big-endian working again.

631. By Kristian Nielsen <knielsen@odin> on 2008-11-28

Fix a couple of memcpy() that should be memmove() (caused by wrong
elimination of bmove(), I think there are more lurking in there).

630. By Kristian Nielsen <knielsen@odin> on 2008-11-28

Make sure that all NULL bits are initialised in records returned from InnoDB.

Failing to do this causes Valgrind errors, and could potentially lead to
unexpected/wrong results when eg. Table::compare_record() compares the
un-initialized bits.

629. By Brian Aker on 2008-11-26

Merge of Monty's work.

628. By Brian Aker on 2008-11-26

Collection of dead code removal

627. By Brian Aker on 2008-11-26

Fixes for OSX