Merge lp:~kklimonda/indicator-application/lp-547072 into lp:indicator-application/0.4

[Krzysztof Klimonda]

Fixes bug 547072 by making a GtkStatusIcon use the same mechanism to choose the right icon as indicator-application uses.

[lp:~kklimonda/indicator-application/lp-547072]

111. By Krzysztof Klimonda on 2010-03-25

Make app_indicator_set_property also set the suffixed icon_name.

112. By Krzysztof Klimonda on 2010-03-25

use gchar instead of for the clarity

[Ted Gould (ted)]

review: Approve

=== modified file 'src/libappindicator/app-indicator.c'
--- src/libappindicator/app-indicator.c	2010-03-19 21:46:41 +0000
+++ src/libappindicator/app-indicator.c	2010-03-25 18:58:25 +0000
@@ -43,6 +43,8 @@
 
 #include "dbus-shared.h"
 
+#define PANEL_ICON_SUFFIX  "panel"
+
 /**
 	AppIndicatorPrivate:
 	@id: The ID of the indicator.  Maps to AppIndicator::id.
@@ -140,6 +142,7 @@
 static void status_icon_changes (AppIndicator * self, gpointer data);
 static void status_icon_activate (GtkStatusIcon * icon, gpointer data);
 static void unfallback (AppIndicator * self, GtkStatusIcon * status_icon);
+static gchar * append_panel_icon_suffix (const gchar * icon_name);
 static void watcher_proxy_destroyed (GObject * object, gpointer data);
 static void client_menu_changed (GtkWidget *widget, GtkWidget *child, AppIndicator *indicator);
 static void submenu_changed (GtkWidget *widget, GtkWidget *child, gpointer data);
@@ -450,6 +453,7 @@
 {
         AppIndicator *self = APP_INDICATOR (object);
         AppIndicatorPrivate *priv = self->priv;
+        gchar *long_name;
         const gchar *instr;
         GEnumValue *enum_val;
 
@@ -500,7 +504,8 @@
               if (priv->icon_name)
                 g_free (priv->icon_name);
 
-              priv->icon_name = g_strdup (instr);
+              long_name = append_panel_icon_suffix (instr);
+              priv->icon_name = long_name;
 
               g_signal_emit (self, signals[NEW_ICON], 0, TRUE);
             }
@@ -900,6 +905,23 @@
 	return;
 }
 
+/* A helper function that appends PANEL_ICON_SUFFIX to the given icon name
+   if it's missing. */
+static gchar *
+append_panel_icon_suffix (const gchar *icon_name)
+{
+	gchar * long_name = NULL;
+
+	if (!g_str_has_suffix (icon_name, PANEL_ICON_SUFFIX)) {
+		long_name =
+		    g_strdup_printf("%s-%s", icon_name, PANEL_ICON_SUFFIX);
+        } else {
+           	long_name = g_strdup (icon_name);
+        }
+
+	return long_name;	
+}
+
 
 /* ************************* */
 /*    Public Functions       */
@@ -1001,6 +1023,8 @@
 void
 app_indicator_set_attention_icon (AppIndicator *self, const gchar *icon_name)
 {
+  gchar *long_name;
+
   g_return_if_fail (IS_APP_INDICATOR (self));
   g_return_if_fail (icon_name != NULL);
 
@@ -1009,7 +1033,8 @@
       if (self->priv->attention_icon_name)
         g_free (self->priv->attention_icon_name);
 
-      self->priv->attention_icon_name = g_strdup (icon_name);
+      long_name = append_panel_icon_suffix (icon_name);
+      self->priv->attention_icon_name = long_name;
 
       g_signal_emit (self, signals[NEW_ATTENTION_ICON], 0, TRUE);
     }
@@ -1027,6 +1052,8 @@
 void
 app_indicator_set_icon (AppIndicator *self, const gchar *icon_name)
 {
+  gchar *long_name;
+
   g_return_if_fail (IS_APP_INDICATOR (self));
   g_return_if_fail (icon_name != NULL);
 
@@ -1035,7 +1062,8 @@
       if (self->priv->icon_name)
         g_free (self->priv->icon_name);
 
-      self->priv->icon_name = g_strdup (icon_name);
+      long_name = append_panel_icon_suffix (icon_name);
+      self->priv->icon_name = long_name;
 
       g_signal_emit (self, signals[NEW_ICON], 0, TRUE);
     }