Merge lp:~kjtehprogrammer/pantheon-files/breadcrumb-copy into lp:~elementary-apps/pantheon-files/trunk

[KJ Lawrence]

Adds ability to copy the path of a breadcrumb by right-click context menu

"Copy Path" added to right-click context menu for breadcrumbs. A minor feature that would be nice to have... Along the lines of https://blueprints.launchpad.net/pantheon-files/+spec/get-full-path-of-window, but isn't as complex to do!

[Jeremy Wootten (jeremywootten)]

A similar feature could be added to the context menus of the views and bookmarks too. My only concern is whether the utility of it warrants lengthening the menus. Something the UI team needs to decide I guess.

[KJ Lawrence (kjtehprogrammer)]

> A similar feature could be added to the context menus of the views and
> bookmarks too. My only concern is whether the utility of it warrants
> lengthening the menus. Something the UI team needs to decide I guess.

If it's not in those menus at least it's possible to to visit it and copy through the breadcrumb! I'm not sure if being the first item in the context menu or being called "Copy Path" is best, that's a UI team thing too.

[Jeremy Wootten (jeremywootten)]

Your branch lp:~kjtehprogrammer/pantheon-files/editable-pathbar makes this branch less needed now, doesn't it?

[KJ Lawrence (kjtehprogrammer)]

Pretty much. It's still not the worst thing to have a copy option when right-clicking the breadcrumbs, but it isn't as necessary now.

[xapantu (xapantu)]

Still, it is interesting. But your fix does not work properly for network shares for instance. Otherwise, it looks fine.

review: Needs Fixing

Unmerged revisions

1445. By KJ Lawrence on 2014-03-15

Add the ability to copy the path to a breadcrumb by right-click context menu item.

=== modified file 'src/View/LocationBar.vala'
--- src/View/LocationBar.vala	2013-09-19 19:06:44 +0000
+++ src/View/LocationBar.vala	2014-03-15 01:28:21 +0000
@@ -279,7 +279,16 @@
         }
 
         private void on_files_loaded_menu () {
-            // First the "Open in new tab" menuitem is added to the menu.
+            // First, add "Copy Path" menu item
+            var menuitem_copypath = new Gtk.MenuItem.with_label (_("Copy Path"));
+            menu.append (menuitem_copypath);
+            menuitem_copypath.activate.connect (() => {
+                Gtk.Clipboard clipboard = Gtk.Clipboard.get_for_display(Gdk.Display.get_default(), Gdk.SELECTION_CLIPBOARD);
+                File loc = File.new_for_uri(current_right_click_path);
+                clipboard.set_text(loc.get_path(), -1);
+            });
+        
+            // Second, add "Open in new tab" menuitem is added to the menu.
             var menuitem_newtab = new Gtk.MenuItem.with_label (_("Open in New Tab"));
             menu.append (menuitem_newtab);
             menuitem_newtab.activate.connect (() => {
@@ -409,4 +418,4 @@
                         Gtk.get_current_event_time ());
         }
     }
-}
+}
\ No newline at end of file