Merge lp:~kjtehprogrammer/maya/fix-1300569 into lp:~elementary-apps/maya/trunk

Proposed by KJ Lawrence
Status: Merged
Merged at revision: 545
Proposed branch: lp:~kjtehprogrammer/maya/fix-1300569
Merge into: lp:~elementary-apps/maya/trunk
Diff against target: 30 lines (+2/-7)
2 files modified
src/Application.vala (+1/-6)
src/View/MayaToolbar.vala (+1/-1)
To merge this branch: bzr merge lp:~kjtehprogrammer/maya/fix-1300569
Reviewer Review Type Date Requested Status
Cody Garver (community) Needs Fixing
Corentin Noël Needs Fixing
Review via email: mp+213966@code.launchpad.net

Commit message

Fixes today not selecting the right day.

Description of the change

Fixes "Today" action

To post a comment you must log in.
Revision history for this message
Corentin Noël (tintou) wrote :

You indeed have fixed the bug, great !
Please remove the lines 9, 10 and 11 from diffs as the today variable is no more used.

review: Needs Fixing
Revision history for this message
KJ Lawrence (kjtehprogrammer) wrote :

Gone!

Revision history for this message
RabbitBot (rabbitbot-a) wrote :

Attempt to merge into lp:maya failed due to conflicts:

text conflict in src/Application.vala
text conflict in src/View/MayaToolbar.vala

Revision history for this message
Cody Garver (codygarver) wrote :

You need to bzr merge lp:maya, then resolve conflicts, make sure it compiles, and push the updated code to this branch. Comment when it's ready

review: Needs Fixing

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/Application.vala'
2--- src/Application.vala 2014-03-24 22:15:29 +0000
3+++ src/Application.vala 2014-04-04 02:31:59 +0000
4@@ -355,12 +355,7 @@
5 }
6
7 void on_menu_today_toggled () {
8-
9- var today = new DateTime.now_local ();
10-
11- if (calmodel.month_start.get_month () != today.get_month ())
12- calmodel.month_start = Util.get_start_of_month ();
13-
14+ calmodel.month_start = Util.get_start_of_month ();
15 calview.today ();
16 }
17
18
19=== modified file 'src/View/MayaToolbar.vala'
20--- src/View/MayaToolbar.vala 2014-03-05 15:49:19 +0000
21+++ src/View/MayaToolbar.vala 2014-04-04 02:31:59 +0000
22@@ -100,7 +100,7 @@
23
24 button_add.clicked.connect (() => add_calendar_clicked ());
25 button_calendar_sources.clicked.connect (on_tb_sources_clicked);
26- today.activate.connect (() => on_menu_today_toggled);
27+ today.activate.connect (() => { on_menu_today_toggled (); });
28 fullscreen.toggled.connect (on_toggle_fullscreen);
29 weeknumbers.toggled.connect (on_menu_show_weeks_toggled);
30 about.activate.connect (() => {

Subscribers

People subscribed via source and target branches