Bazaar

Merge lp:~kiyuko/bzr/gnu-changelog into lp:~bzr/bzr/trunk-old

  1. gnu-changelog
  2. Merge into trunk-old
Proposed by Andrea Bolognani
Status: Merged
Approved by: Martin Pool
Approved revision: 4133
Merge reported by: Martin Pool
Merged at revision: not available
Proposed branch: lp:~kiyuko/bzr/gnu-changelog
Merge into: lp:~bzr/bzr/trunk-old
Diff against target: 1 lines
To merge this branch: bzr merge lp:~kiyuko/bzr/gnu-changelog
Reviewer Review Type Date Requested Status
Martin Pool Approve
James Westby Approve
Review via email: mp+4402@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Andrea Bolognani (kiyuko) wrote :

Improve slightly the GNU ChangeLog format.

Revision history for this message
James Westby (james-w) :
review: Approve
Revision history for this message
Martin Pool (mbp) wrote :

revision.delta.has_changed ():

According to pep8 there should be no space before the parens.

review: Approve
lp:~kiyuko/bzr/gnu-changelog updated
4133. By Andrea Bolognani

Remove whitespace between function name and parens.

Revision history for this message
Andrea Bolognani (kiyuko) wrote :

> "revision.delta.has_changed ():
>
> According to pep8 there should be no space before the parens."

Sorry, I'm not really confident with the Python coding style.

I've tried to follow bzr's style as closely as possible, but I just missed this one. Fixed.

Revision history for this message
Martin Pool (mbp) wrote :

Thanks, I'll merge it.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'bzrlib/log.py'