Merge lp:~kiwinote/software-center/bug905605 into lp:software-center

Proposed by Kiwinote
Status: Merged
Merged at revision: 2616
Proposed branch: lp:~kiwinote/software-center/bug905605
Merge into: lp:software-center
Diff against target: 26 lines (+8/-0)
2 files modified
debian/changelog (+7/-0)
softwarecenter/ui/gtk3/widgets/oneconfviews.py (+1/-0)
To merge this branch: bzr merge lp:~kiwinote/software-center/bug905605
Reviewer Review Type Date Requested Status
Michael Vogt Pending
Review via email: mp+87257@code.launchpad.net

Description of the change

this is a consequence of http://git.gnome.org/browse/pygobject/commit/gi/overrides/Gtk.py?id=654711d0f940d7480d0f1cdb25a3dc9996f7a706
although that commit breaks existing applications the change isn't incorrect in the sense that we do declare the column type as a string so we should really ensure that we only put strings in (which is what i've done here)

To post a comment you must log in.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/changelog'
2--- debian/changelog 2011-12-19 13:12:41 +0000
3+++ debian/changelog 2012-01-02 15:12:26 +0000
4@@ -1,3 +1,10 @@
5+software-center (5.1.5) UNRELEASED; urgency=low
6+
7+ * softwarecenter/ui/gtk3/widgets/oneconfviews.py:
8+ - ensure that hostid is always a string (as we declared) (LP: #905605)
9+
10+ -- Kiwinote <kiwinote@gmail.com> Mon, 02 Jan 2012 15:03:47 +0000
11+
12 software-center (5.1.4) precise; urgency=low
13
14 [ Michael Vogt ]
15
16=== modified file 'softwarecenter/ui/gtk3/widgets/oneconfviews.py'
17--- softwarecenter/ui/gtk3/widgets/oneconfviews.py 2011-09-02 03:53:36 +0000
18+++ softwarecenter/ui/gtk3/widgets/oneconfviews.py 2012-01-02 15:12:26 +0000
19@@ -67,6 +67,7 @@
20 return
21 if hostid in self.hostids:
22 return
23+ hostid = hostid or '' # bug 905605
24 self.hostids.append(hostid)
25 LOG.debug("register new computer: %s, %s" % (hostname, hostid))
26 model.append([self.default_computer_icon, hostid, hostname])

Subscribers

People subscribed via source and target branches