PlainBox (Toolkit)

Merge ~kissiel/plainbox:exporters-fix into plainbox:master

  1. Git
  2. lp:~kissiel/plainbox
  3. exporters-fix
  4. Merge into master
Proposed by Maciej Kisielewski
Status: Merged
Approved by: Sylvain Pineau
Approved revision: fe7dab5435b2e9e83d475d0a3ec6f7bb860c8769
Merged at revision: 89d04d3b6252ddcce0ec7abe4f998cd94e453866
Proposed branch: ~kissiel/plainbox:exporters-fix
Merge into: plainbox:master
Diff against target: 13 lines (+1/-1)
1 file modified
plainbox/impl/commands/cmd_session.py (+1/-1)
Reviewer Review Type Date Requested Status
Sylvain Pineau (community) Approve
Review via email: mp+315660@code.launchpad.net

Description of the change

Fixes problem with exporting sessions when using --output-format options.

To test it run

`plainbox session export $ANY_EXISTING_SESSION --output-format text`

To find existing sessions, run `plainbox session`

To post a comment you must log in.
Revision history for this message
Sylvain Pineau (sylvain-pineau) wrote :

Good catch, +1. Let's preserve the speed improvements you made to this code by not checking the possible values (as it means loading all units).

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/plainbox/impl/commands/cmd_session.py b/plainbox/impl/commands/cmd_session.py
2index cb41241..c7b1cd6 100644
3--- a/plainbox/impl/commands/cmd_session.py
4+++ b/plainbox/impl/commands/cmd_session.py
5@@ -112,7 +112,7 @@ class SessionCommand(PlainBoxCommand):
6 group = export_parser.add_argument_group(_("output options"))
7 group.add_argument(
8 '-f', '--output-format', default='text',
9- metavar=_('FORMAT'), choices=[_('?')],
10+ metavar=_('FORMAT'),
11 help=_('save test results in the specified FORMAT'
12 ' (pass ? for a list of choices)'))
13 group.add_argument(

Subscribers

People subscribed via source and target branches