lp:~kissiel/checkbox/password-dialog

Branch merges

Propose for merging

No branches dependent on this one.

Merged into lp:checkbox at revision 3768

Zygmunt Krynicki (community): Approve on 2015-05-12

Diff: 473 lines (+358/-24)

5 files modified

checkbox-touch/components/CheckboxTouchApplication.qml (+5/-0)
checkbox-touch/components/PasswordDialog.qml (+88/-0)
checkbox-touch/main.qml (+51/-22)
checkbox-touch/py/checkbox_touch.py (+30/-2)
checkbox-touch/py/sudo_with_pass_ctrl.py (+184/-0)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Bug #1382974: Elevated privilege test fails

High

Fix Released

Link a bug report

Related blueprints

3597. By Maciej Kisielewski on 2015-03-10

checkbox-touch: make checkbox-touch ask for password

This patch adds PasswordDialog to mainView of Checkbox-Touch. The dialog is
popped whenever Checkbox-Touch stumbles upon a job with user field defined.
This patch also stores (redundant) flag on qml side, informing whether password
has already been sent to CheckboxTouchApp on python side. This optimisation
saves hustle of storing the password on QML side and resending it every time
it's required by the execution controller.

Signed-off-by: Maciej Kisielewski <email address hidden>

3596. By Maciej Kisielewski on 2015-03-10

checkbox-touch: add rememberPassword to App component on QML side

This patch adds rememberPassword function to qml side of things. It uses direct
py.call to dodge any logging of password string.

Signed-off-by: Maciej Kisielewski <email address hidden>

3595. By Maciej Kisielewski on 2015-03-10

checkbox-touch: use custom execution controllers

This patch make Checkbox-Touch use two execution controllers to run jobs. For
'current-user' jobs it uses UserJobExecutionController, and for jobs with
'user' field present it uses RootViaSudoWithPassExecutionController.

Signed-off-by: Maciej Kisielewski <email address hidden>

3594. By Maciej Kisielewski on 2015-03-10

checkbox-touch: add storing of password in CheckboxTouchApplication

This patch adds storing of password in instances of CheckboxTouchApplication.

Signed-off-by: Maciej Kisielewski <email address hidden>

3593. By Maciej Kisielewski on 2015-03-10

checkbox-touch: add PasswordDialog

This patch introduces new popup that prompts user for password. The dialog
comes embedded in a Component, which in turn is contained in an Item for ease
of use.

3592. By Maciej Kisielewski on 2015-03-10

checkbox-touch: add RootViaSudoWithPassExecutionController

This patch adds execution controller that uses sudo to obtain root and writes
password to subprocess' stdin.

Signed-off-by: Maciej Kisielewski <email address hidden>

3591. By Maciej Kisielewski on 2015-03-10

checkbox-touch: move perform*Test calls to distinctive function

This patch moves code related to picking the correct perform*Test function
depending on plugin type, to performTest function. This simplifies the code to
come.

Signed-off-by: Maciej Kisielewski <email address hidden>

3590. By Maciej Kisielewski on 2015-03-10

checkbox-touch: add job's user field to 'test' model

This patch makes 'get_next_test' attach user field to the 'test' model return
through pyotherside to qml.

Signed-off-by: Maciej Kisielewski <email address hidden>

3589. By Sylvain Pineau on 2015-02-23

"automatic merge of lp:~sylvain-pineau/checkbox/14.04-client-testplan/ by tarmac [r=apulido][bug=][author=sylvain-pineau]"

3588. By Launchpad Translations on behalf of checkbox-dev on 2015-02-21

Launchpad automatic translations update.