Merge lp:~kissiel/checkbox/fix-unicode into lp:checkbox

[Maciej Kisielewski]

This MR solves a bunch of problems that happened on systems with bad locale settings.

Instead of crashing, checkbox-cli now displays a warning and ignores characters that cannot be printed.

To test it run: $ LC_ALL=en_US checkbox-cli, select any test plan and proceed till finish.

For terminals with utf-8 encoding, behaviour is unchanged.

68efedb plainbox:exporter: ignore non-printable characters on certain terminals
f70908b plainbox:exporter: fix PEP-8 issue

[Maciej Kisielewski (kissiel)]

Self-approving, as it was reviewed here: https://code.launchpad.net/~kissiel/checkbox/fix-unicode/+merge/277553, but due to broken pushes it reverted the patches, and LP marked the MR as merged.

review: Approve

=== modified file 'plainbox/plainbox/impl/exporter/__init__.py'
--- plainbox/plainbox/impl/exporter/__init__.py	2015-07-16 21:25:01 +0000
+++ plainbox/plainbox/impl/exporter/__init__.py	2015-11-24 16:47:35 +0000
@@ -31,8 +31,6 @@
 from logging import getLogger
 import base64
 
-import pkg_resources
-
 from plainbox.i18n import gettext as _
 from plainbox.abc import ISessionStateExporter
 from plainbox.impl import deprecated
@@ -380,4 +378,14 @@
             object's specified encoding prior to writing.
             :param data: the chunk of data to write.
         """
+        if (self.dest_stream.encoding and
+                self.dest_stream.encoding.lower() != self.encoding.lower()):
+            logger.warning(
+                _("Incorrect stream encoding. Got %s, expected %s. "
+                  " some characters won't be printed"),
+                self.dest_stream.encoding, self.encoding)
+            # fall back to ASCII encoding
+            return self.dest_stream.write(data.decode(
+                'ascii', errors='ignore'))
+
         return self.dest_stream.write(data.decode(self.encoding))