Merge lp:~kissiel/checkbox/fix-selection-on-vivid into lp:checkbox

Proposed by Maciej Kisielewski
Status: Merged
Approved by: Sylvain Pineau
Approved revision: 3723
Merged at revision: 3726
Proposed branch: lp:~kissiel/checkbox/fix-selection-on-vivid
Merge into: lp:checkbox
Diff against target: 11 lines (+1/-0)
1 file modified
checkbox-touch/components/SelectionPage.qml (+1/-0)
To merge this branch: bzr merge lp:~kissiel/checkbox/fix-selection-on-vivid
Reviewer Review Type Date Requested Status
Sylvain Pineau (community) Approve
Review via email: mp+257494@code.launchpad.net

Description of the change

This MR fixes a problem with selection screen Vivid. On Trusty, tapping on a label on the selection screen resulted selecting/deselecting that particular item. This didn't work on Vivid by default.
This patch/MR fixes that problem.

To post a comment you must log in.
Revision history for this message
Sylvain Pineau (sylvain-pineau) wrote :

Does it affect the Trusty default behaviour? (I mean the addition of the line)

review: Needs Information
Revision history for this message
Maciej Kisielewski (kissiel) wrote :

> Does it affect the Trusty default behaviour? (I mean the addition of the line)

I tested on Utopic and Vivid. Did not test on 14.04 (trusty)

Revision history for this message
Sylvain Pineau (sylvain-pineau) wrote :

Ok, let's land it. Running cbt on 14.04 is another problem. +1

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'checkbox-touch/components/SelectionPage.qml'
2--- checkbox-touch/components/SelectionPage.qml 2015-04-07 17:55:36 +0000
3+++ checkbox-touch/components/SelectionPage.qml 2015-04-27 08:22:29 +0000
4@@ -186,6 +186,7 @@
5 selectedCount += checked ? 1 : -1;
6 }
7 }
8+ onClicked: checkBox.clicked()
9 }
10 section.property: "mod_group" // NOTE: this is a model reference
11 section.criteria: ViewSection.FullString

Subscribers

People subscribed via source and target branches