lp:~kissiel/checkbox/fix-1585030

Branch merges

Propose for merging

No branches dependent on this one.

Merged into lp:checkbox at revision 4376

Paul Larson: Approve on 2016-05-24

Diff: 32 lines (+6/-3)

1 file modified

checkbox-touch/py/checkbox_touch.py (+6/-3)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Bug #1585030: Checkbox converged will hang on the welcome page when you roll back from the test case selection page

Critical

Fix Released

Link a bug report

Related blueprints

4375. By Maciej Kisielewski on 2016-05-24

checkbox-touch: fix freeze when going back to welcome page

So the crash happened because SessionAssistant wasn't expecting to get
get_test_plans calls when we're negotiating which tests to run.

There were handful of ways to fix it, namely:

1) Rebooting the session (finalizing, starting one afresh), this would require
maintaining information whether the session was already started. This would be
expensive to run (starting session). Note that we do this if the user changes
their mind about which test plan to run, as then we need to bootstrap
everything.

2) Letting get_test_plans be called in different stages of the session's
maturation process. This would bring allowed_calls extension in couple of
places, making SA code uglier and less linear in terms of session lifetime.

3) Remembering available test plans in the app state. Test plans don't change
once session is started, so this is safe. Note that once test plan is selected
the session will be rebooted.

I went with 3). Least code and least collateral additions.

Fixes: https://bugs.launchpad.net/checkbox-converged/+bug/1585030

Signed-off-by: Maciej Kisielewski <email address hidden>

4374. By Maciej Kisielewski on 2016-05-23

"automatic merge of lp:~kissiel/checkbox/provider-supplied-libs/ by tarmac [r=pwlars][bug=1584103][author=kissiel]"

4373. By Paul Larson on 2016-05-23

"automatic merge of lp:~pwlars/checkbox/impl-unit-flakes/ by tarmac [r=taihsiangho][bug=][author=pwlars]"

4372. By Sylvain Pineau on 2016-05-23

"automatic merge of lp:~sylvain-pineau/checkbox/die_local.txt_die/ by tarmac [r=pwlars][bug=][author=sylvain-pineau]"

4371. By Sylvain Pineau on 2016-05-23

"automatic merge of lp:~sylvain-pineau/checkbox/cli2-removal-bis/ by tarmac [r=sylvain-pineau][bug=][author=sylvain-pineau]"

4370. By Launchpad Translations on behalf of checkbox-dev on 2016-05-23

Launchpad automatic translations update.

4369. By Launchpad Translations on behalf of checkbox-dev on 2016-05-21

Launchpad automatic translations update.

4368. By Launchpad Translations on behalf of checkbox-dev on 2016-05-20

Launchpad automatic translations update.

4367. By Po-Hsu Lin on 2016-05-20

"automatic merge of lp:~cypressyew/checkbox/cbt-update/ by tarmac [r=cypressyew][bug=][author=cypressyew]"

4366. By Sylvain Pineau on 2016-05-19

"automatic merge of lp:~sylvain-pineau/checkbox/fix-1577831/ by tarmac [r=pwlars][bug=1577831][author=sylvain-pineau]"