Checkbox

Merge lp:~kissiel/checkbox/fix-1503958-preserve-ordering-from-tp into lp:checkbox

  1. fix-1503958-preserve-ordering-from-tp
  2. Merge into trunk
Proposed by Maciej Kisielewski
Status: Merged
Approved by: Po-Hsu Lin
Approved revision: 4040
Merged at revision: 4047
Proposed branch: lp:~kissiel/checkbox/fix-1503958-preserve-ordering-from-tp
Merge into: lp:checkbox
Diff against target: 13 lines (+2/-1)
1 file modified
plainbox/plainbox/impl/session/assistant.py (+2/-1)
To merge this branch: bzr merge lp:~kissiel/checkbox/fix-1503958-preserve-ordering-from-tp
Reviewer Review Type Date Requested Status
Po-Hsu Lin Approve
Review via email: mp+274124@code.launchpad.net

Description of the change

This MR makes session assistant preserve job ordering as it was specified by the test plan when narrowing down selection.

275dd58 plainbox:session:assistant: preserve job ordering from tp
68fe7c2 plainbox:session:assistant: fix pep-8 issues

To post a comment you must log in.
Revision history for this message
Po-Hsu Lin (cypressyew) wrote :

Verified on the same laptop, it works!
Thanks!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'plainbox/plainbox/impl/session/assistant.py'
2--- plainbox/plainbox/impl/session/assistant.py 2015-10-05 19:11:35 +0000
3+++ plainbox/plainbox/impl/session/assistant.py 2015-10-12 10:30:38 +0000
4@@ -676,7 +676,8 @@
5 """
6 UsageExpectation.of(self).enforce()
7 desired_job_list = [
8- self._context.get_unit(job_id, 'job') for job_id in selection]
9+ self._context.get_unit(job_id, 'job') for job_id in
10+ self.get_static_todo_list() if job_id in selection]
11 self._context.state.update_desired_job_list(desired_job_list)
12
13 @raises(UnexpectedMethodCall)

Subscribers

People subscribed via source and target branches