Merge lp:~kissiel/checkbox/fix-1501500-resume-after-tp-selected into lp:checkbox

Proposed by Maciej Kisielewski
Status: Merged
Approved by: Zygmunt Krynicki
Approved revision: 4086
Merged at revision: 4086
Proposed branch: lp:~kissiel/checkbox/fix-1501500-resume-after-tp-selected
Merge into: lp:checkbox
Diff against target: 12 lines (+2/-0)
1 file modified
checkbox-touch/py/checkbox_touch.py (+2/-0)
To merge this branch: bzr merge lp:~kissiel/checkbox/fix-1501500-resume-after-tp-selected
Reviewer Review Type Date Requested Status
Zygmunt Krynicki (community) Approve
Review via email: mp+276346@code.launchpad.net

Description of the change

This MR fixes a resume session problem for sessions suspended just after test plan selection screen.

3083714 checkbox-touch: ignore resumable sessions having no app_blob

As we're trying to blindly deserialize app_blob from the last valid incomplete session, we need to make sure that we actually can do this. This patch adds checking if the items returned as resumable sessions by session assistant contain app_blob.

This patch doesn't change anything in the session assistant, as a session  checkpoint without app_blob is not invalid.

To post a comment you must log in.
Revision history for this message
Zygmunt Krynicki (zyga) wrote :

+1, thanks

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'checkbox-touch/py/checkbox_touch.py'
2--- checkbox-touch/py/checkbox_touch.py 2015-10-28 08:38:46 +0000
3+++ checkbox-touch/py/checkbox_touch.py 2015-11-01 15:11:34 +0000
4@@ -223,6 +223,8 @@
5 def is_session_resumable(self):
6 """Check whether there is a session that can be resumed."""
7 for session_id, session_md in self.assistant.get_resumable_sessions():
8+ if session_md.app_blob is None:
9+ continue
10 # we're interested in the latest session only, this is why we
11 # return early
12 self._latest_session = session_id

Subscribers

People subscribed via source and target branches