Checkbox

Merge lp:~kissiel/checkbox/fix-1492322-better-add-comment-button into lp:checkbox

  1. fix-1492322-better-add-comment-button
  2. Merge into trunk
Proposed by Maciej Kisielewski
Status: Merged
Approved by: Zygmunt Krynicki
Approved revision: 4001
Merged at revision: 4003
Proposed branch: lp:~kissiel/checkbox/fix-1492322-better-add-comment-button
Merge into: lp:checkbox
Diff against target: 77 lines (+6/-6)
6 files modified
checkbox-touch/components/InteractIntroPage.qml (+1/-1)
checkbox-touch/components/ManualIntroPage.qml (+1/-1)
checkbox-touch/components/QmlConfinedPage.qml (+1/-1)
checkbox-touch/components/QmlNativePage.qml (+1/-1)
checkbox-touch/components/TestVerificationPage.qml (+1/-1)
checkbox-touch/components/UserInteractSummaryPage.qml (+1/-1)
To merge this branch: bzr merge lp:~kissiel/checkbox/fix-1492322-better-add-comment-button
Reviewer Review Type Date Requested Status
Zygmunt Krynicki (community) Approve
Review via email: mp+270820@code.launchpad.net

Description of the change

This MR replaces icon that was used as 'add comment' header action to one that doesn't look like a disabled one.

d3bbd61 checkbox-touch: change 'add comment' header icon

To post a comment you must log in.
Revision history for this message
Zygmunt Krynicki (zyga) wrote :

+1

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'checkbox-touch/components/InteractIntroPage.qml'
2--- checkbox-touch/components/InteractIntroPage.qml 2015-08-18 12:59:01 +0000
3+++ checkbox-touch/components/InteractIntroPage.qml 2015-09-11 13:45:30 +0000
4@@ -50,7 +50,7 @@
5 actions: [
6 Action {
7 id: addCommentAction
8- iconName: "document-new-symbolic"
9+ iconName: "note-new"
10 text: i18n.tr("Add comment")
11 onTriggered: {
12 commentsDialog.commentDefaultText = test["comments"] || "";
13
14=== modified file 'checkbox-touch/components/ManualIntroPage.qml'
15--- checkbox-touch/components/ManualIntroPage.qml 2015-08-18 12:59:01 +0000
16+++ checkbox-touch/components/ManualIntroPage.qml 2015-09-11 13:45:30 +0000
17@@ -44,7 +44,7 @@
18 actions: [
19 Action {
20 id: addCommentAction
21- iconName: "document-new-symbolic"
22+ iconName: "note-new"
23 text: i18n.tr("Add comment")
24 onTriggered: {
25 commentsDialog.commentDefaultText = test["comments"] || "";
26
27=== modified file 'checkbox-touch/components/QmlConfinedPage.qml'
28--- checkbox-touch/components/QmlConfinedPage.qml 2015-08-18 12:59:01 +0000
29+++ checkbox-touch/components/QmlConfinedPage.qml 2015-09-11 13:45:30 +0000
30@@ -78,7 +78,7 @@
31 actions: [
32 Action {
33 id: addCommentAction
34- iconName: "document-new-symbolic"
35+ iconName: "note-new"
36 text: i18n.tr("Add comment")
37 onTriggered: {
38 commentsDialog.commentDefaultText = test["comments"] || "";
39
40=== modified file 'checkbox-touch/components/QmlNativePage.qml'
41--- checkbox-touch/components/QmlNativePage.qml 2015-08-18 12:59:01 +0000
42+++ checkbox-touch/components/QmlNativePage.qml 2015-09-11 13:45:30 +0000
43@@ -51,7 +51,7 @@
44 actions: [
45 Action {
46 id: addCommentAction
47- iconName: "document-new-symbolic"
48+ iconName: "note-new"
49 text: i18n.tr("Add comment")
50 onTriggered: {
51 commentsDialog.commentDefaultText = test["comments"] || "";
52
53=== modified file 'checkbox-touch/components/TestVerificationPage.qml'
54--- checkbox-touch/components/TestVerificationPage.qml 2015-08-18 12:59:01 +0000
55+++ checkbox-touch/components/TestVerificationPage.qml 2015-09-11 13:45:30 +0000
56@@ -44,7 +44,7 @@
57 actions: [
58 Action {
59 id: addCommentAction
60- iconName: "document-new-symbolic"
61+ iconName: "note-new"
62 text: i18n.tr("Add comment")
63 onTriggered: {
64 commentsDialog.commentDefaultText = test["comments"] || "";
65
66=== modified file 'checkbox-touch/components/UserInteractSummaryPage.qml'
67--- checkbox-touch/components/UserInteractSummaryPage.qml 2015-08-18 12:59:01 +0000
68+++ checkbox-touch/components/UserInteractSummaryPage.qml 2015-09-11 13:45:30 +0000
69@@ -44,7 +44,7 @@
70 actions: [
71 Action {
72 id: addCommentAction
73- iconName: "document-new-symbolic"
74+ iconName: "note-new"
75 text: i18n.tr("Add comment")
76 onTriggered: {
77 commentsDialog.commentDefaultText = test["comments"] || "";

Subscribers

People subscribed via source and target branches