Merge lp:~kissiel/checkbox/fix-1492319-yes-no-rename into lp:checkbox

Proposed by Maciej Kisielewski
Status: Merged
Approved by: Zygmunt Krynicki
Approved revision: 4001
Merged at revision: 4004
Proposed branch: lp:~kissiel/checkbox/fix-1492319-yes-no-rename
Merge into: lp:checkbox
Diff against target: 21 lines (+2/-2)
1 file modified
checkbox-touch/components/TestVerificationPage.qml (+2/-2)
To merge this branch: bzr merge lp:~kissiel/checkbox/fix-1492319-yes-no-rename
Reviewer Review Type Date Requested Status
Zygmunt Krynicki (community) Approve
Review via email: mp+270815@code.launchpad.net

Description of the change

This MR renames'Yes' and 'No' buttons to 'Pass' and 'Fail' on the test verification page.

Test verification screen now shows 'Pass' and 'Fail' buttons that should better express what they do.

0031ff8 checkbox-touch: rename 'Yes' and 'No' buttons to 'Pass' and 'Fail'

To post a comment you must log in.
Revision history for this message
Zygmunt Krynicki (zyga) wrote :

±1

Later on we should probably use outcome meta-data APIs to access localized name for the two.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'checkbox-touch/components/TestVerificationPage.qml'
2--- checkbox-touch/components/TestVerificationPage.qml 2015-08-18 12:59:01 +0000
3+++ checkbox-touch/components/TestVerificationPage.qml 2015-09-11 13:19:24 +0000
4@@ -125,7 +125,7 @@
5 objectName: "passButton"
6 unlatchedColor: UbuntuColors.green
7 Layout.fillWidth: true
8- text: i18n.tr("Yes")
9+ text: i18n.tr("Pass")
10 onLatchedClicked: {
11 test["outcome"] = "pass";
12 latchingTestDone();
13@@ -138,7 +138,7 @@
14 objectName: "failButton"
15 unlatchedColor: UbuntuColors.red
16 Layout.fillWidth: true
17- text: i18n.tr("No")
18+ text: i18n.tr("Fail")
19 onLatchedClicked: {
20 test["outcome"] = "fail";
21 latchingTestDone();

Subscribers

People subscribed via source and target branches