Merge lp:~kissiel/checkbox/fix-1470811-show-desc-steps-ver-at-once into lp:checkbox

[Maciej Kisielewski]

This MR changes how plainbox handles interactive jobs in the command-line.
1) Steps field is always printed before the test starts its activity. This way the user knows how to prepare for the activity before it starts.
2) For manual tests, there is no introductory prompt. Everything is printed at the beginning of the test and the only interaction with the user is regarding the outcome.

c9925bc plainbox:commands:inv_run: move first prompt in interactive jobs to after steps
7bd6ddd plainbox:commands:inv_run: remove intro prompt for manual jobs

[Zygmunt Krynicki (zyga)]

+1, thanks!

review: Approve

=== modified file 'plainbox/plainbox/impl/commands/inv_run.py'
--- plainbox/plainbox/impl/commands/inv_run.py	2015-07-01 09:41:39 +0000
+++ plainbox/plainbox/impl/commands/inv_run.py	2015-07-03 10:40:11 +0000
@@ -798,9 +798,12 @@
                         job.plugin in ('user-interact',
                                        'user-interact-verify',
                                        'manual')):
-                    cmd = ui.wait_for_interaction_prompt(job)
+                    ui.notify_about_steps(job)
+                    if job.plugin == 'manual':
+                        cmd = 'run'
+                    else :
+                        cmd = ui.wait_for_interaction_prompt(job)
                     if cmd == 'run' or cmd is None:
-                        ui.notify_about_steps(job)
                         result_builder = self.runner.run_job(
                             job, job_state, self.config, ui
                         ).get_builder()