Merge lp:~kissiel/checkbox/fix-1453070-print-header-name into lp:checkbox

Proposed by Maciej Kisielewski
Status: Merged
Approved by: Zygmunt Krynicki
Approved revision: no longer in the source branch.
Merged at revision: 3767
Proposed branch: lp:~kissiel/checkbox/fix-1453070-print-header-name
Merge into: lp:checkbox
Diff against target: 23 lines (+3/-0)
1 file modified
plainbox/plainbox/impl/commands/inv_run.py (+3/-0)
To merge this branch: bzr merge lp:~kissiel/checkbox/fix-1453070-print-header-name
Reviewer Review Type Date Requested Status
Zygmunt Krynicki (community) Approve
Review via email: mp+258838@code.launchpad.net

Description of the change

This MR makes CLI front-ends print 'Purpose:', 'Steps:' and 'Verificaiton:'
text before printing contents of the corresponding fields. This should make
interaction with plainbox more digestable.

To post a comment you must log in.
Revision history for this message
Zygmunt Krynicki (zyga) wrote :

+1

review: Approve
3766. By Maciej Kisielewski

"automatic merge of lp:~kissiel/checkbox/autopilot-fixes/ by tarmac [r=zyga][bug=][author=kissiel]"

3767. By Maciej Kisielewski

"automatic merge of lp:~kissiel/checkbox/fix-1453070-print-header-name/ by tarmac [r=zyga][bug=][author=kissiel]"

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'plainbox/plainbox/impl/commands/inv_run.py'
2--- plainbox/plainbox/impl/commands/inv_run.py 2015-04-21 15:28:03 +0000
3+++ plainbox/plainbox/impl/commands/inv_run.py 2015-05-12 07:29:26 +0000
4@@ -214,16 +214,19 @@
5
6 def notify_about_purpose(self, job):
7 if job.tr_purpose() is not None:
8+ print(self.C.CYAN(_("Purpose:")))
9 print(self.C.CYAN(job.tr_purpose()))
10 else:
11 self.notify_about_description(job)
12
13 def notify_about_steps(self, job):
14 if job.tr_steps() is not None:
15+ print(self.C.CYAN(_("Steps:")))
16 print(self.C.CYAN(job.tr_steps()))
17
18 def notify_about_verification(self, job):
19 if job.tr_verification() is not None:
20+ print(self.C.CYAN(_("Verification:")))
21 print(self.C.CYAN(job.tr_verification()))
22
23 def job_cannot_start(self, job, job_state, result):

Subscribers

People subscribed via source and target branches