Merge lp:~kissiel/checkbox/fix-1445001 into lp:checkbox

[Maciej Kisielewski]

This MR makes reruning not hide some of the tests. It does so by not updating 'main' runlist, but by using rerun candidates list instead.

[Zygmunt Krynicki (zyga)]

+1 from me, I'll let Sam approve if it works for him

review: Approve

[Po-Hsu Lin (cypressyew)]

+1, thanks

result page after re-run (with the same test case in the bug report)
==================================[ Results ]===================================
 ☑ : cpuinfo
 ☑ : package
 ☑ : lsb
 ☑ : requirements
 ☑ : uname
 ☑ : dmi
 ☑ : dpkg
 ☒ : IEEE_80211
 ☑ : block_device
 ☑ : cdimage
 ☑ : device
 ☑ : display
 ☑ : efi
 ☑ : environment
 ☑ : gconf
 ☑ : meminfo
 ☑ : mobilebroadband
 ☑ : module
 ☑ : rtc
 ☑ : sleep
 ☑ : usb
 ☑ : xinput
 ☑ : audio/list_devices
 ☐ : audio/playback_headphones
 ☑ : audio/playback_auto
 ☑ : Hardware Manifest
 ☑ : camera/detect
 ☑ : camera/still

review: Approve

=== modified file 'checkbox-ng/checkbox_ng/commands/newcli.py'
--- checkbox-ng/checkbox_ng/commands/newcli.py	2015-04-16 13:06:00 +0000
+++ checkbox-ng/checkbox_ng/commands/newcli.py	2015-04-17 10:58:28 +0000
@@ -518,9 +518,8 @@
         # bail-out early if no job qualifies for rerunning
         if not rerun_candidates:
             return
-        self._update_desired_job_list(rerun_candidates)
         tree = SelectableJobTreeNode.create_tree(
-            self.manager.state, self.manager.state.run_list)
+            self.manager.state, rerun_candidates)
         # deselect all by default
         tree.set_descendants_state(False)
         self.display.run(ShowRerun(tree, _("Select jobs to re-run")))
@@ -533,5 +532,4 @@
         # reset outcome of jobs that are selected for re-running
         for job in wanted_set:
             self.manager.state.job_state_map[job.id].result.outcome = None
-        self._update_desired_job_list(rerun_job_list)
         self.run_all_selected_jobs()