Merge lp:~kissiel/checkbox/fix-1420352 into lp:checkbox

Proposed by Maciej Kisielewski on 2015-02-11
Status: Merged
Approved by: Zygmunt Krynicki on 2015-02-11
Approved revision: 3575
Merged at revision: 3575
Proposed branch: lp:~kissiel/checkbox/fix-1420352
Merge into: lp:checkbox
Diff against target: 11 lines (+1/-1)
1 file modified
plainbox/plainbox/impl/secure/providers/v1.py (+1/-1)
To merge this branch: bzr merge lp:~kissiel/checkbox/fix-1420352
Reviewer Review Type Date Requested Status
Zygmunt Krynicki (community) 2015-02-11 Approve on 2015-02-11
Review via email: mp+249271@code.launchpad.net

Description of the change

This MR makes WhiteListPlugIn delazify text content of file when creating
TestPlanUnit. Not doing so kept text as LazyFileContent which made plainbox not
guess the role of the file, breaking serialization of that unit which is
needed when comparing units.

540d8cc plainbox:secure:providers: delazify content when creating testplan unit

To post a comment you must log in.
Zygmunt Krynicki (zyga) wrote :

Hey, thanks for fixing this, +1

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'plainbox/plainbox/impl/secure/providers/v1.py'
2--- plainbox/plainbox/impl/secure/providers/v1.py 2015-02-06 15:51:41 +0000
3+++ plainbox/plainbox/impl/secure/providers/v1.py 2015-02-11 00:07:23 +0000
4@@ -199,7 +199,7 @@
5 'unit': TestPlanUnit.Meta.name,
6 'id': name,
7 'name': name,
8- 'include': text,
9+ 'include': str(text), # delazify content
10 }, origin=origin, provider=provider, field_offset_map=field_offset_map,
11 virtual=True)
12

Subscribers

People subscribed via source and target branches