Checkbox

Merge lp:~kissiel/checkbox/fix-1412458 into lp:checkbox

  1. fix-1412458
  2. Merge into trunk
Proposed by Maciej Kisielewski
Status: Merged
Approved by: Zygmunt Krynicki
Approved revision: 3534
Merged at revision: 3534
Proposed branch: lp:~kissiel/checkbox/fix-1412458
Merge into: lp:checkbox
Diff against target: 12 lines (+1/-1)
1 file modified
checkbox-touch/main.qml (+1/-1)
To merge this branch: bzr merge lp:~kissiel/checkbox/fix-1412458
Reviewer Review Type Date Requested Status
Zygmunt Krynicki (community) Approve
Review via email: mp+246906@code.launchpad.net

Description of the change

This MR fixes a problem, where qmlscene would report error about trying to read attribute from undefined when setting progress header's label.

cba9220 checkbox-touch: don't read the title of a non-existent page

To post a comment you must log in.
Revision history for this message
Zygmunt Krynicki (zyga) wrote :

+1

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'checkbox-touch/main.qml'
2--- checkbox-touch/main.qml 2014-12-11 22:27:53 +0000
3+++ checkbox-touch/main.qml 2015-01-19 15:01:07 +0000
4@@ -172,7 +172,7 @@
5 rightMargin: units.gu(1)
6 }
7 Label {
8- text: pageStack.currentPage.title
9+ text: pageStack.currentPage ? pageStack.currentPage.title : ""
10 fontSize: "x-large"
11 font.weight: Font.Light
12 anchors.verticalCenter: parent.verticalCenter

Subscribers

People subscribed via source and target branches