Merge lp:~kissiel/checkbox/converged-fixes into lp:checkbox

[Maciej Kisielewski]

This MR adds python3-requests-oauthlib

and makes it easier for the future to find out there are missing libs, instead of just showing cryptic 'test plan missing' pop-up.

7b01cdc plainbox:secure:plugins: don't mark plugincollection as loaded unless it is
322c5e3 plainbox:session:assistant: log-error problems from loading providers
dcb3b46 checkbox-touch: add python3-requests-oauthlib to get-libs

[Paul Larson (pwlars)]

I don't see where python3-requests-oauthlib actually gets used here, maybe it was always a missing dep? How was this tested and can I also test it?

review: Needs Information

[Maciej Kisielewski (kissiel)]

> I don't see where python3-requests-oauthlib actually gets used here, maybe it
> was always a missing dep? How was this tested and can I also test it?

It's a dependency of plainbox. On the device, when the providers are being loaded, the pkg_resources finds this lib missing it stops loading the provider mid-way. No test plans are available afterwards.

To test it, build checkbox-converged and run it on a device.

Simplest way:

cd checkbox-touch
./get-libs
./build-me --install

[Paul Larson (pwlars)]

+1

review: Approve

=== modified file 'checkbox-touch/get-libs'
--- checkbox-touch/get-libs	2015-11-16 10:20:39 +0000
+++ checkbox-touch/get-libs	2016-04-04 18:35:25 +0000
@@ -72,7 +72,8 @@
                 'python3-extras', 'python3-evdev']
     packages = ['libpython3.4', 'pyotherside', 'python3-xlsxwriter',
                 'python3-jinja2', 'python3-markupsafe', 'python3-padme',
-                'python3-requests', 'python3-urllib3', 'python3-guacamole']
+                'python3-requests', 'python3-urllib3', 'python3-guacamole',
+                'python3-requests-oauthlib']
     if get_autopilot:
         packages += ap_packages
     # uris will serve as a database of uris from which to download packages
@@ -220,7 +221,8 @@
     # ./usr/lib/python3/dist-packages are copied to ./lib/py.
     python3_libs = ['python3-xlsxwriter', 'python3-jinja2',
                     'python3-markupsafe', 'python3-padme', 'python3-requests',
-                    'python3-urllib3', 'python3-guacamole']
+                    'python3-urllib3', 'python3-guacamole',
+                    'python3-requests-oauthlib']
 
     # additional libs needed to support autopilot tests.  these were obtained by
     # running apt-cache depends on python3-autopilot

=== modified file 'plainbox/plainbox/impl/secure/plugins.py'
--- plainbox/plainbox/impl/secure/plugins.py	2015-02-06 15:30:54 +0000
+++ plainbox/plainbox/impl/secure/plugins.py	2016-04-04 18:35:25 +0000
@@ -480,7 +480,6 @@
         """
         if self._loaded:
             return
-        self._loaded = True
         start_time = now()
         entry_point_list = list(self._get_entry_points())
         entry_point_list.sort(key=lambda ep: ep.name)
@@ -495,6 +494,7 @@
             else:
                 self.wrap_and_add_plugin(
                     entry_point.name, obj, now() - start_time)
+        self._loaded = True
 
     def _get_entry_points(self):
         """

=== modified file 'plainbox/plainbox/impl/session/assistant.py'
--- plainbox/plainbox/impl/session/assistant.py	2016-03-02 14:01:49 +0000
+++ plainbox/plainbox/impl/session/assistant.py	2016-04-04 18:35:25 +0000
@@ -564,6 +564,10 @@
         self._manager = SessionManager.create(self._repo)
         self._context = self._manager.add_local_device_context()
         for provider in self._selected_providers:
+            if provider.problem_list:
+                _logger.error(
+                    "Problems encountered when loading %s provider: %s",
+                    provider.name, provider.problem_list)
             self._context.add_provider(provider)
         self._metadata = self._context.state.metadata
         self._metadata.app_id = self._app_id