Merge lp:~kissiel/checkbox/autopilot-testing into lp:checkbox
| Status: | Superseded |
|---|---|
| Proposed branch: | lp:~kissiel/checkbox/autopilot-testing |
| Merge into: | lp:checkbox |
| Diff against target: |
460 lines (+108/-136) 15 files modified
checkbox-touch/Makefile (+2/-1) checkbox-touch/README.rst (+1/-1) checkbox-touch/build-me (+3/-2) checkbox-touch/checkbox-touch.qml (+34/-17) checkbox-touch/checkbox-touch.qmlproject (+1/-1) checkbox-touch/components/CheckboxTouchApplication.qml (+4/-4) checkbox-touch/py/checkbox_touch.py (+19/-6) checkbox-touch/tests/autopilot/autopilot-provider/jobs/autopilot.pxu (+7/-0) checkbox-touch/tests/autopilot/autopilot-provider/manage.py (+21/-0) checkbox-touch/tests/autopilot/checkbox_touch/__init__.py (+1/-0) checkbox-touch/tests/autopilot/checkbox_touch/test_checkbox_touch.py (+12/-0) checkbox-touch/tests/autopilot/checkbox_touch/test_latch_button.py (+0/-16) checkbox-touch/tests/autopilot/checkbox_touch/test_manual_intro_page.py (+0/-35) checkbox-touch/tests/autopilot/checkbox_touch/test_resume_session_screen.py (+0/-52) checkbox-touch/tests/autopilot/run (+3/-1) |
| To merge this branch: | bzr merge lp:~kissiel/checkbox/autopilot-testing |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Maciej Kisielewski | Approve on 2015-03-20 | ||
| Zygmunt Krynicki (community) | Approve on 2015-03-20 | ||
|
Review via email:
|
|||
This proposal supersedes a proposal from 2015-03-09.
This proposal has been superseded by a proposal from 2015-03-22.
Description of the Change
This MR lays foundations for autopilot testing for checkbox touch.
Major changes/additions are:
* Addition of Utopic as a target in test-in-lxc
* Addition of per-release requirements provisioning
* Move from main.qml to checkbox-touch.qml as the 'entry point' to CBT
* Add option to run CBT in autopilot-y way
b660802 checkbox-touch: add basic autopilot test
fe8d162 checkbox-touch: add autopilot tests to container-tests
0cff0e5 test-in-lxc: make test-in-lxc run tests on utopic
0e2fb89 checkbox-touch: make autopilot tests fail if autopilot is not installed
15d5bec checkbox-touch: make `make autopilot` run ./get-libs first
1dba042 support: make install-
86d9f2a checkbox-touch: use absolute paths for autopilot provider
90e5d25 checkbox-touch: make autopilot run CBT with '--autopilot option'
e0f9b84 checkbox-touch: remove old autopilot tests
1e53580 checkbox-touch: make checkbox-touch.qml entry point to the app
bfba415 checkbox-touch: add providersDir to generated settings.json
946e613 checkbox-touch: add --autopilot option to main.qml
37df775 checkbox-touch: make APP_DIR fall back to '.'
b113a33 checkbox-touch: be explicit about where to load providers from
| Maciej Kisielewski (kissiel) wrote : | # |
> Question: The test in lxc containers is what we're running when MR are
> proposed and this script is only called by the tarmac lander, right?
AFAIK yes. tarmac-verify runs test-in-lxc if TEST_RUNNER is not defined or set to lxc.
> I'm
> trying to make the difference between the test actually run when building a
> ppa in a build environment (ppa) from tests run with tarmac in containers.
> I ask because I see that you're using lsb_release in a couple of places but
> IIRC such tool is not available in a build env.
>
> And finally rev 3594, you're mentioning an autopilot provider, do we have such
> thing in the known providers?
Yeah, even empty autopilot provider is required. I just added it and repushed the branch. Sorry for missing it in original MR.
| Sylvain Pineau (sylvain-pineau) wrote : | # |
ok, thank for the quick fix.
I've tested it in a VM and it works well (Results here: http://
+1
| Daniel Manrique (roadmr) wrote : | # |
The attempt to merge lp:~kissiel/checkbox/autopilot-testing into lp:checkbox failed. Below is the output from the failed tests.
[precise] starting container
[precise] (timing) 0.07user 0.02system 0:04.25elapsed 2%CPU (0avgtext+0avgdata 7852maxresident)k
[precise] (timing) 0inputs+32outputs (0major+
[precise] provisioning container
[precise] (timing) 39.58user 12.69system 1:31.80elapsed 56%CPU (0avgtext+0avgdata 51820maxresident)k
[precise] (timing) 0inputs+
[precise-testing] Starting tests...
Found a test script: ./checkbox-
[precise-testing] container-
[precise-testing] (timing) 29.34user 2.18system 0:31.93elapsed 98%CPU (0avgtext+0avgdata 116196maxresident)k
[precise-testing] (timing) 0inputs+4240outputs (0major+
Found a test script: ./checkbox-
[precise-testing] container-
[precise-testing] (timing) 0.67user 0.13system 0:00.83elapsed 96%CPU (0avgtext+0avgdata 40976maxresident)k
[precise-testing] (timing) 0inputs+3880outputs (0major+
Found a test script: ./checkbox-
[precise-testing] container-
[precise-testing] (timing) 15.51user 0.18system 0:15.81elapsed 99%CPU (0avgtext+0avgdata 83228maxresident)k
[precise-testing] (timing) 0inputs+1032outputs (0major+
Found a test script: ./checkbox-
[precise-testing] container-
[precise-testing] (timing) 0.02user 0.01system 0:00.05elapsed 67%CPU (0avgtext+0avgdata 4696maxresident)k
[precise-testing] (timing) 0inputs+8outputs (0major+
Found a test script: ./checkbox-
[precise-testing] container-
[precise-testing] (timing) 0.00user 0.00system 0:00.02elapsed 28%CPU (0avgtext+0avgdata 2044maxresident)k
[precise-testing] (timing) 0inputs+8outputs (0major+
Found a test script: ./plainbox/
[precise-testing] container-
[precise-testing] (timing) 0.22user 0.03system 0:00.28elapsed 93%CPU (0avgtext+0avgdata 15356maxresident)k
[precise-testing] (timing) 0inputs+176outputs (0major+
Found a test script: ./plainbox/
[precise-testing] 001-container-
[precise-testing] (timing) 0.14user 0.04system 0:00.20elapsed 91%CPU (0avgtext+0avgdata 10544maxresident)k
[precise-testing] (timing) 0inputs+88outputs (0major+
Found a test script: ./plainbox/
[precise-testing] container-
[precise-testing] (timing) 12.66user 0.82...
| Maciej Kisielewski (kissiel) wrote : | # |
Added 'thumbnailer-
Self aproving to retry the merge.
| Daniel Manrique (roadmr) wrote : | # |
The attempt to merge lp:~kissiel/checkbox/autopilot-testing into lp:checkbox failed. Below is the output from the failed tests.
[precise] starting container
[precise] (timing) 0.06user 0.03system 0:05.27elapsed 1%CPU (0avgtext+0avgdata 7852maxresident)k
[precise] (timing) 0inputs+32outputs (0major+
[precise] provisioning container
[precise] (timing) 39.96user 12.85system 1:31.60elapsed 57%CPU (0avgtext+0avgdata 51824maxresident)k
[precise] (timing) 0inputs+
[precise-testing] Starting tests...
Found a test script: ./checkbox-
[precise-testing] container-
[precise-testing] (timing) 27.69user 2.23system 0:30.31elapsed 98%CPU (0avgtext+0avgdata 116196maxresident)k
[precise-testing] (timing) 0inputs+4240outputs (0major+
Found a test script: ./checkbox-
[precise-testing] container-
[precise-testing] (timing) 0.68user 0.12system 0:00.84elapsed 96%CPU (0avgtext+0avgdata 40976maxresident)k
[precise-testing] (timing) 0inputs+3880outputs (0major+
Found a test script: ./checkbox-
[precise-testing] container-
[precise-testing] (timing) 17.37user 0.10system 0:18.26elapsed 95%CPU (0avgtext+0avgdata 83096maxresident)k
[precise-testing] (timing) 0inputs+1032outputs (0major+
Found a test script: ./checkbox-
[precise-testing] container-
[precise-testing] (timing) 0.01user 0.02system 0:00.05elapsed 69%CPU (0avgtext+0avgdata 4696maxresident)k
[precise-testing] (timing) 0inputs+8outputs (0major+
Found a test script: ./checkbox-
[precise-testing] container-
[precise-testing] (timing) 0.00user 0.00system 0:00.02elapsed 42%CPU (0avgtext+0avgdata 2044maxresident)k
[precise-testing] (timing) 0inputs+8outputs (0major+
Found a test script: ./plainbox/
[precise-testing] container-
[precise-testing] (timing) 0.20user 0.05system 0:00.28elapsed 92%CPU (0avgtext+0avgdata 15356maxresident)k
[precise-testing] (timing) 0inputs+176outputs (0major+
Found a test script: ./plainbox/
[precise-testing] 001-container-
[precise-testing] (timing) 0.15user 0.06system 0:00.23elapsed 92%CPU (0avgtext+0avgdata 10548maxresident)k
[precise-testing] (timing) 0inputs+88outputs (0major+
Found a test script: ./plainbox/
[precise-testing] container-
[precise-testing] (timing) 12.78user 0.85...
| Maciej Kisielewski (kissiel) wrote : | # |
Disabled GLX for autopilot tests.
| Daniel Manrique (roadmr) wrote : | # |
The attempt to merge lp:~kissiel/checkbox/autopilot-testing into lp:checkbox failed. Below is the output from the failed tests.
[precise] starting container
[precise] (timing) 0.05user 0.03system 0:05.22elapsed 1%CPU (0avgtext+0avgdata 7860maxresident)k
[precise] (timing) 0inputs+32outputs (0major+
[precise] provisioning container
[precise] (timing) 39.59user 11.16system 1:37.06elapsed 52%CPU (0avgtext+0avgdata 51820maxresident)k
[precise] (timing) 0inputs+
[precise-testing] Starting tests...
Found a test script: ./checkbox-
[precise-testing] container-
[precise-testing] (timing) 29.82user 2.02system 0:32.24elapsed 98%CPU (0avgtext+0avgdata 116196maxresident)k
[precise-testing] (timing) 0inputs+4240outputs (0major+
Found a test script: ./checkbox-
[precise-testing] container-
[precise-testing] (timing) 0.56user 0.13system 0:00.95elapsed 73%CPU (0avgtext+0avgdata 40976maxresident)k
[precise-testing] (timing) 0inputs+3880outputs (0major+
Found a test script: ./checkbox-
[precise-testing] container-
[precise-testing] (timing) 15.48user 0.12system 0:16.07elapsed 97%CPU (0avgtext+0avgdata 83112maxresident)k
[precise-testing] (timing) 0inputs+1032outputs (0major+
Found a test script: ./checkbox-
[precise-testing] container-
[precise-testing] (timing) 0.02user 0.01system 0:00.05elapsed 66%CPU (0avgtext+0avgdata 4692maxresident)k
[precise-testing] (timing) 0inputs+8outputs (0major+
Found a test script: ./checkbox-
[precise-testing] container-
[precise-testing] (timing) 0.00user 0.00system 0:00.03elapsed 35%CPU (0avgtext+0avgdata 2044maxresident)k
[precise-testing] (timing) 0inputs+8outputs (0major+
Found a test script: ./plainbox/
[precise-testing] container-
[precise-testing] (timing) 0.18user 0.06system 0:00.27elapsed 93%CPU (0avgtext+0avgdata 15360maxresident)k
[precise-testing] (timing) 0inputs+176outputs (0major+
Found a test script: ./plainbox/
[precise-testing] 001-container-
[precise-testing] (timing) 0.14user 0.04system 0:00.19elapsed 90%CPU (0avgtext+0avgdata 10548maxresident)k
[precise-testing] (timing) 0inputs+88outputs (0major+
Found a test script: ./plainbox/
[precise-testing] container-
[precise-testing] (timing) 12.13user 0.78...
| Zygmunt Krynicki (zyga) wrote : | # |
Please rebase, also look at two inline comments below.
- 3624. By Maciej Kisielewski on 2015-03-20
-
checkbox-touch: be explicit about where to load providers from
This patch makes all chain of calls responsible for loading providers in
Checkbox-Touch explicit about the path from which to load providers from.
This paves the way for autopilot provider to be loaded on the side of normal
providers.Signed-off-by: Maciej Kisielewski <email address hidden>
- 3625. By Maciej Kisielewski on 2015-03-20
-
checkbox-touch: make APP_DIR fall back to '.'
This patch makes Checkbox-Touch expand APP_DIR envvar to '.' when it's absent.
This makes loading of local providers on desktop work as expected.
Signed-off-by: Maciej Kisielewski <email address hidden> - 3626. By Maciej Kisielewski on 2015-03-20
-
checkbox-touch: add --autopilot option to main.qml
This patch adds an option to run Checkbox-Touch in autopilot mode, that changes
path from which providers are loaded and preselects autopilot testplan.Signed-off-by: Maciej Kisielewski <email address hidden>
- 3627. By Maciej Kisielewski on 2015-03-20
-
checkbox-touch: add providersDir to generated settings.json
Signed-off-by: Maciej Kisielewski <email address hidden>
- 3628. By Maciej Kisielewski on 2015-03-20
-
checkbox-touch: remove checkbox-touch.qml symlink
Signed-off-by: Maciej Kisielewski <email address hidden>
- 3629. By Maciej Kisielewski on 2015-03-20
-
checkbox-touch: rename main.qml to checkbox-touch.qml
Signed-off-by: Maciej Kisielewski <email address hidden>
- 3630. By Maciej Kisielewski on 2015-03-20
-
checkbox-touch: make checkbox-touch.qml entry point to the app
This patch changes main file to be checkbox-touch.qml instead of main.
Except the obvious improvement, which is clarity, it makes it compliant with
the default behaviour autopilot takes when trying to launch app.Signed-off-by: Maciej Kisielewski <email address hidden>
- 3631. By Maciej Kisielewski on 2015-03-20
-
checkbox-touch: remove old autopilot tests
Signed-off-by: Maciej Kisielewski <email address hidden>
- 3632. By Maciej Kisielewski on 2015-03-20
-
checkbox-touch: make autopilot run CBT with '--autopilot option'
This patch makes autopilot tests run Checkbox-Touch with '--autopilot' option
by default.Signed-off-by: Maciej Kisielewski <email address hidden>
- 3633. By Maciej Kisielewski on 2015-03-20
-
checkbox-touch: use absolute paths for autopilot provider
This patch makes Checkbox-Touch use correct absolute path when building path to
autopilot provider files.Signed-off-by: Maciej Kisielewski <email address hidden>
- 3634. By Maciej Kisielewski on 2015-03-20
-
checkbox-touch: make `make autopilot` run ./get-libs first
Signed-off-by: Maciej Kisielewski <email address hidden>
- 3635. By Maciej Kisielewski on 2015-03-20
-
checkbox-touch: make autopilot tests fail if autopilot is not installed
This patch fixes a false positive feedback when runnning autopilot without
having it installed.Signed-off-by: Maciej Kisielewski <email address hidden>
- 3636. By Maciej Kisielewski on 2015-03-20
-
checkbox-touch: add autopilot provider
This patch adds empty provider that is used when running autopilot tests. All
future autopilot scenarios should base on jobs defined in this provider.Signed-off-by: Maciej Kisielewski <email address hidden>
- 3637. By Maciej Kisielewski on 2015-03-20
-
checkbox-touch: add basic autopilot test
This patch adds an autopilot test that checks if app can be launched.
Signed-off-by: Maciej Kisielewski <email address hidden>
| Zygmunt Krynicki (zyga) wrote : | # |
+1, thanks, looking forward towards resolving infrastructure issues to see all your work in practice!
Unmerged revisions
- 3637. By Maciej Kisielewski on 2015-03-20
-
checkbox-touch: add basic autopilot test
This patch adds an autopilot test that checks if app can be launched.
Signed-off-by: Maciej Kisielewski <email address hidden>
- 3636. By Maciej Kisielewski on 2015-03-20
-
checkbox-touch: add autopilot provider
This patch adds empty provider that is used when running autopilot tests. All
future autopilot scenarios should base on jobs defined in this provider.Signed-off-by: Maciej Kisielewski <email address hidden>
- 3635. By Maciej Kisielewski on 2015-03-20
-
checkbox-touch: make autopilot tests fail if autopilot is not installed
This patch fixes a false positive feedback when runnning autopilot without
having it installed.Signed-off-by: Maciej Kisielewski <email address hidden>
- 3634. By Maciej Kisielewski on 2015-03-20
-
checkbox-touch: make `make autopilot` run ./get-libs first
Signed-off-by: Maciej Kisielewski <email address hidden>
- 3633. By Maciej Kisielewski on 2015-03-20
-
checkbox-touch: use absolute paths for autopilot provider
This patch makes Checkbox-Touch use correct absolute path when building path to
autopilot provider files.Signed-off-by: Maciej Kisielewski <email address hidden>
- 3632. By Maciej Kisielewski on 2015-03-20
-
checkbox-touch: make autopilot run CBT with '--autopilot option'
This patch makes autopilot tests run Checkbox-Touch with '--autopilot' option
by default.Signed-off-by: Maciej Kisielewski <email address hidden>
- 3631. By Maciej Kisielewski on 2015-03-20
-
checkbox-touch: remove old autopilot tests
Signed-off-by: Maciej Kisielewski <email address hidden>
- 3630. By Maciej Kisielewski on 2015-03-20
-
checkbox-touch: make checkbox-touch.qml entry point to the app
This patch changes main file to be checkbox-touch.qml instead of main.
Except the obvious improvement, which is clarity, it makes it compliant with
the default behaviour autopilot takes when trying to launch app.Signed-off-by: Maciej Kisielewski <email address hidden>
- 3629. By Maciej Kisielewski on 2015-03-20
-
checkbox-touch: rename main.qml to checkbox-touch.qml
Signed-off-by: Maciej Kisielewski <email address hidden>
- 3628. By Maciej Kisielewski on 2015-03-20
-
checkbox-touch: remove checkbox-touch.qml symlink
Signed-off-by: Maciej Kisielewski <email address hidden>


Question: The test in lxc containers is what we're running when MR are proposed and this script is only called by the tarmac lander, right? I'm trying to make the difference between the test actually run when building a ppa in a build environment (ppa) from tests run with tarmac in containers.
I ask because I see that you're using lsb_release in a couple of places but IIRC such tool is not available in a build env.
And finally rev 3594, you're mentioning an autopilot provider, do we have such thing in the known providers?