Merge ~kissiel/checkbox-support:fix-dkms-parser-entry-point into checkbox-support:master

Proposed by Maciej Kisielewski
Status: Merged
Approved by: Maciej Kisielewski
Approved revision: a8f1550c962f52c718de9e33789e39e99f23129f
Merged at revision: 93747ac22db4f426f72ab239b2e125a41acca41f
Proposed branch: ~kissiel/checkbox-support:fix-dkms-parser-entry-point
Merge into: checkbox-support:master
Diff against target: 13 lines (+1/-1)
1 file modified
checkbox_support/parsers/__init__.py (+1/-1)
Reviewer Review Type Date Requested Status
Jonathan Cave (community) Approve
Review via email: mp+418595@code.launchpad.net

Description of the change

fix: change the name of the dkms parser to dkms-info

Fixes: LP: #1960584

To post a comment you must log in.
Revision history for this message
Maciej Kisielewski (kissiel) wrote :

Some context:
My patch for parser refactor broke it by having the parser name "dkms" instead of "dkms-info".
This led to parsing failing (on stderr) which made JQ ignore process nothing yielding nothing.
Then the jinja2-based json exporter yielded `"dkms-info":` without anything after the colon, breaking the json.

Revision history for this message
Jonathan Cave (jocave) wrote :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/checkbox_support/parsers/__init__.py b/checkbox_support/parsers/__init__.py
2index 7797414..dd928d8 100644
3--- a/checkbox_support/parsers/__init__.py
4+++ b/checkbox_support/parsers/__init__.py
5@@ -42,7 +42,7 @@ from checkbox_support.parsers import udevadm
6 AVAILABLE_PARSERS = {
7 'bto': image_info.parse_bto_attachment_output,
8 'buildstamp': image_info.parse_buildstamp_attachment_output,
9- 'dkms': dkms_info.parse_dkms_info,
10+ 'dkms-info': dkms_info.parse_dkms_info,
11 'dmidecode': dmidecode.parse_dmidecode_output,
12 'kernelcmdline': kernel_cmdline.parse_kernel_cmdline,
13 'modinfo': modinfo.parse_modinfo_attachment_output,

Subscribers

People subscribed via source and target branches