~kissiel/checkbox-ng:fix-1966045-crash-on-startup

Branch merges

Propose for merging

Merged into checkbox-ng:master at revision 511e6f6e7f2e29ed994dabfba614097d722caa08

Jonathan Cave (community): Approve on 2022-03-23

Diff: 116 lines (+36/-10)

4 files modified

checkbox_ng/launcher/subcommands.py (+3/-3)
plainbox/impl/session/assistant.py (+17/-1)
plainbox/impl/session/remote_assistant.py (+3/-3)
plainbox/impl/session/restart.py (+13/-3)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related charm recipes

27efa7f... by Maciej Kisielewski on 2022-03-23

Fix: better naming of remote sessions

87b736e... by Maciej Kisielewski on 2022-03-23

Fix: traceback when launching checkbox

This patch adds an optional arg to detect_restart_strategy so the information
that the session is remote can be used to pick the best strategy.
There's a bit of heuristic in the SessionAssistant class that guesses that the
session is remote by looking at its title - remote sessions have
'checkbox-slave' in the session's title.

Fixes: LP: #1966045

1941bac... by Ubuntu <email address hidden> on 2022-03-21

Merge #417166 from ~sylvain-pineau/checkbox-ng:fix-CVE-2021-44731

9611605... by Sylvain Pineau on 2022-03-21

restart.py: Check for RemoteDebRestartStrategy support first

Due to snapd CVE-2021-44731, the checkbox remote service now runs outside
confinement but fakes env var like SNAP and SNAP_DATA.

The auto detection mechanism must check the RemoteDebRestartStrategy first
because the new systemd service is also named checkbox-ng.service like for
debian packages.

Sharing the same restart strategy logic as debs can only work if the code
using on_ubuntucore() is never reached in this use case.

1f12940... by Ubuntu <email address hidden> on 2022-01-24

Merge #411951 from ~kissiel/checkbox-ng:fix-provider-develop

4bb52f9... by Ubuntu <email address hidden> on 2022-01-23

Merge #414359 from ~kissiel/checkbox-ng:fix-1957187

f0b7375... by Maciej Kisielewski on 2021-11-16

Fix: use universal provider "develop" path

Previously running "develop" subcommand on the manage.py resulted in the
.provider file being created somewhere in user's home. Because of that the
service (which is run as root) did not see it resulting in no "develop"-ed
providers via remote. This patch fixes that problem.

c9e572e... by Maciej Kisielewski on 2021-11-16

Add: inform that the $PROVIDERPATH is defined

This way there's no nasty surprise when the providers aren't loaded properly.

e237a90... by Maciej Kisielewski on 2022-01-19

Fix: tracebacks on wrong secureID in auto-sessions

Fixes LP: #1957187

76fd5f9... by Ubuntu <email address hidden> on 2022-01-17

Merge #414009 from ~kissiel/checkbox-ng:arabian-nights-are-good-too