Merge ~kissiel/checkbox-ng:fix-1957187 into checkbox-ng:master

[Maciej Kisielewski]

This patch fixes an issue where traceback would be printed when secureID was wrong and the session was an automated one.

[Sylvain Pineau (sylvain-pineau)]

+1 to remove the traceback, not sure it actually solves the problem of the empty secure id though.

review: Approve

[Maciej Kisielewski (kissiel)]

It fixes the traceback :D

The handing over of secureID still needs to be fixed. But that's not a Checkbox jurisdiction anymore.

diff --git a/checkbox_ng/launcher/stages.py b/checkbox_ng/launcher/stages.py
index 84bdfe1..126324b 100644
--- a/checkbox_ng/launcher/stages.py
+++ b/checkbox_ng/launcher/stages.py
@@ -511,6 +511,11 @@ class ReportsStage(CheckboxUiStage):
                         continue
                 except InvalidSecureIDError:
                     _logger.warning(_("Invalid secure_id"))
+                    if not self.is_interactive:
+                        # secure_id will not magically change if the session
+                        # is a non-interactive one, so let's stop trying
+                        done_sending = True
+                        continue
                     if self._retry_dialog():
                         self.sa.config.transports['c3'].pop('secure_id')
                         continue